search

Pryaxis / TShock

☕️⚡️TShock provides Terraria servers with server-side characters, anti-cheat, and community management tools.
GNU General Public License v3.0
2.41k stars 377 forks source link

Removing food from plate disappears. #1939

Open Patrikkk opened 4 years ago

Patrikkk commented 4 years ago

Removing food from plate disappears.

Reproduction steps (if applicable)?

  1. Place a plate
  2. Place a fruit in it (eg. banana)
  3. Remove the fruit
  4. POOF disappears.

Any stack traces or error messages (if known)?

None

Any screenshots?

Nope

Any log messages from files that end in .log or .txt? What are the last 100 log messages from the server console?

Nope

What plugins and what versions of those plugins are you running?

Empty TShock.

This is most probably related to itemdrop and tileentityupdate packet. (21 and 86)

Olink commented 4 years ago

I assume this is fixed by https://github.com/Pryaxis/TShock/commit/4290d0af1afd852d67ade0b90d326dafe1324b09 ?

Patrikkk commented 4 years ago

No, it is not, that's why I didn't reference the issue. I implemented that event, while I realized that there is an itemdrop issue that is most likely related to the two packets that are processed in Boncer, that I mentioned above. Thought I finish my implementation first, before tackling this issue.

Olink commented 4 years ago

Ah, the more you know tmyk

QuiCM commented 4 years ago

@Patrikkk did this get fixed?