search

Pryaxis / TShock

☕️⚡️TShock provides Terraria servers with server-side characters, anti-cheat, and community management tools.
GNU General Public License v3.0
2.43k stars 382 forks source link

Fishing out Bloodmoon mini bosses is broken #1985

Closed moisterrific closed 4 years ago

moisterrific commented 4 years ago

Reproduction steps (if applicable)?

  1. Set worldevent to bloodmoon
  2. Try to fish out a mini boss (ideally using Golden Rod w/ Master bait and sonar and fishing buffs)
  3. See mini boss or any blood moon fishing mob name indicated by sonar potion
  4. Reel in
  5. Mini boss(es) do not spawn

Any screenshots?

Can post a gif if required.

Any log messages from files that end in .log or .txt? What are the last 100 log messages from the server console?

None

What plugins and what versions of those plugins are you running?

None, only TShockAPI

moisterrific commented 4 years ago

All the mobs you can fish from Bloodmoon fail to spawn

Duke Fishron works fine though

For reference I tested using an owner account and a guest account. Neither were able to spawn blood moon NPCs.

Duke Fishron could not be spawned by guest (no summon boss perm) so that's working as intended.

Patrikkk commented 4 years ago

The OnFishNPC hook in Bouncer does send debug message if a packet is handled. Do you find any messages in your logs starting with "Bouncer / OnFishOutNPC rejected"? So you're saying all mobs dont work, only Duke.

moisterrific commented 4 years ago

Duke is working as intended, just that every other mob you can fish up won't spawn.

There were no debug messages in logs because I forgot to enable DebugLogs lol

moisterrific commented 4 years ago

Alright enabled it and it says this:

2020-06-03 22:48:50 - TextLog: VERBOSE: Bouncer / OnFishOutNPC rejected range checks from moisterrific

I was fishing on a flying mount about a dozen tiles above the ocean if that makes any difference...

Patrikkk commented 4 years ago

Thank you for the test! It was helpful. The issue is patched in the upcoming commit.

moisterrific commented 4 years ago

Great, I’ll leave this open until the next pre-release, so we won’t have duplicate issues.

hakusaro commented 4 years ago

Great, I’ll leave this open until the next pre-release, so we won’t have duplicate issues.

I'm going to close it -- if it's broken we can re-open and we can have other issues closed. Most people don't check for dupes anyway :(

JMCY26 commented 4 years ago

This is present still in V11

Patrikkk commented 4 years ago

Can you please describe what actions you are getting? Is "DebugLogs":enabled in your config? Are you getting any messages related to OnFishOutNPC?