search

Pryaxis / TShock

☕️⚡️TShock provides Terraria servers with server-side characters, anti-cheat, and community management tools.
GNU General Public License v3.0
2.41k stars 377 forks source link

NPC's relocating to wrong area upon death. #2035

Open tlworks opened 4 years ago

tlworks commented 4 years ago

Gold Trim labeled NPC's often relocate to an entirely different house rather than their appointed ones upon NPC death.

NPC's with gold trimmed labels should always return to their previous house where possible, since default players do not have permission to move NPC's nor destroy their houses (protected area) I have concluded that this is a bug.

Reproduction steps (if applicable)?

No applicable steps to reproduce other than getting the NPC killed.

Any stack traces or error messages (if known)?

No logs are available in regards to this issue.

Any screenshots?

For the sake of showing what I mean with "gold trimmed" labels; image

Any log messages from files that end in .log or .txt? What are the last 100 log messages from the server console?

No logs are available regarding this issue.

What plugins and what versions of those plugins are you running?

Naked TShock.

moisterrific commented 4 years ago

Couldn't reproduce this issue on my end, I manually killed a few Town NPCs using the explosive bunny trick, but they all spawned back into the rooms that had the golden trim. I'll try again later with all TownNPCs killed.

moisterrific commented 4 years ago

Tested it again this time with killing all town NPCs (had all of them excluding Santa since this was an endgame world), and they all spawned back in their proper gold trim areas.

Not sure what could be causing them to not respawn at their designated rooms on your end, maybe because there were too many players around? For reference I was testing on a server w/ only myself online.

mpql commented 4 years ago

I have had this happen, and it was the result of many Town NPCs dying, and a non-gold-trimmed one taking the room of someone who had one. Then it was like dominoes. It might be worth making gold-trimmed NPCs spawn first, or somehow making them view a gold-trimmed-NPC-claimed room as off-limits.

Kojirremer commented 4 years ago

I recall this happening on 1.3 as well. When they died once, they retook their assigned house. When dying a second time in the same session, they would forget their house and move to a random one.