search

Pryaxis / TShock

☕️⚡️TShock provides Terraria servers with server-side characters, anti-cheat, and community management tools.
GNU General Public License v3.0
2.43k stars 382 forks source link

/grow cactus/herb doesn't work in certain conditions #2377

Open Arthri opened 3 years ago

Arthri commented 3 years ago

Reproduction steps (if applicable)?

/grow cactus
  1. Find non-sand blocks
  2. /grow cactus
  3. places a sand block, but no cactus

/grow cactus works in sand biomes

/grow herb
  1. Make the 2nd block below you sand
  2. /grow herb
  3. blinkroot breaks client-side because it's trying to grow on sand

/grow herb works on dirt blocks

Any stack traces or error messages (if known)?

N/A

Any screenshots?

(/grow cactus then /grow herb) 17 58 33 608

Any log messages from files that end in .log or .txt? What are the last 100 log messages from the server console?

2021-06-25 17:58:06 - <>c: INFO: Port overridden by startup argument. Set to 7777
2021-06-25 17:58:06 - TextLog: INFO: TShock 4.5.4.0 (Blood Moon edition) now running.
2021-06-25 17:58:06 - TShock: INFO: AutoSave Enabled
2021-06-25 17:58:06 - TShock: INFO: Backups Disabled
2021-06-25 17:58:06 - TShock: INFO: Welcome to TShock for Terraria!
2021-06-25 17:58:06 - TShock: INFO: TShock comes with no warranty & is free software.
2021-06-25 17:58:06 - TShock: INFO: You can modify & distribute it under the terms of the GNU GPLv3.
2021-06-25 17:58:10 - TShock: INFO: Login before join enabled. Users may be prompted for an account specific password instead of a server password on connect.
2021-06-25 17:58:10 - TShock: INFO: Login using UUID enabled. Users automatically login via UUID.
2021-06-25 17:58:10 - TShock: INFO: A malicious server can easily steal a user's UUID. You may consider turning this option off if you run a public server.
2021-06-25 17:58:11 - TextLog: VERBOSE: GetDataHandlers / HandlePlayerBuffList handled event and sent data Test1
2021-06-25 17:58:11 - GetDataHandlers: INFO: Test1 authenticated successfully as user Test1.
2021-06-25 17:58:13 - TShock: INFO: Test1 (127.0.0.1) from 'superadmin' group joined. (1/2)
2021-06-25 17:58:13 - Utils: INFO: Broadcast: Test1 has joined.
2021-06-25 17:58:13 - TextLog: VERBOSE: Bouncer / OnPlayerBuff rejected hostile/pvp from Test1
2021-06-25 17:58:13 - TextLog: VERBOSE: GetDataHandlers / HandlePlayerBuffList handled event and sent data Test1
2021-06-25 17:58:16 - TextLog: VERBOSE: GetDataHandlers / HandlePlayerBuffList handled event and sent data Test1
2021-06-25 17:58:27 - Utils: INFO: Test1 executed: /grow cactus.
2021-06-25 17:58:30 - Utils: INFO: Test1 executed: /grow herb.
2021-06-25 17:58:36 - TextLog: VERBOSE: Bouncer / OnPlayerBuff rejected hostile/pvp from Test1
2021-06-25 17:58:36 - TextLog: VERBOSE: GetDataHandlers / HandlePlayerBuffList handled event and sent data Test1
2021-06-25 17:58:36 - TextLog: VERBOSE: Bouncer / OnPlayerBuff rejected hostile/pvp from Test1
2021-06-25 17:58:36 - TextLog: VERBOSE: GetDataHandlers / HandlePlayerBuffList handled event and sent data Test1
2021-06-25 17:58:40 - Utils: INFO: Broadcast: Test1 has left.
2021-06-25 17:58:40 - TShock: INFO: Test1 disconnected.
2021-06-25 17:58:40 - Utils: INFO: Broadcast: Saving world...
2021-06-25 17:58:40 - Utils: INFO: Broadcast: World saved.
2021-06-25 17:58:40 - SaveManager: INFO: World saved at (C:\Users\[REDACTED]\Documents\My Games\Terraria\Worlds\Test2.wld)
2021-06-25 17:58:52 - Utils: INFO: Server executed: /exit.
2021-06-25 17:58:52 - Utils: INFO: Broadcast: Saving world...
2021-06-25 17:58:53 - Utils: INFO: Broadcast: World saved.
2021-06-25 17:58:53 - SaveManager: INFO: World saved at (C:\Users\[REDACTED]\Documents\My Games\Terraria\Worlds\Test2.wld)
2021-06-25 17:58:53 - Utils: INFO: Broadcast: Server shutting down!

What plugins and what versions of those plugins are you running?

TShock 4.5.4

csmir commented 3 years ago

The code for growing both cactuses and herbs has been the same for previous versions and worked perfectly in the past. It seems possible that a current undiscovered bug has appeared making it 'impossible' to grow these generated types manually.

As I am responsible for upgrading the grow command initially, I feel responsible for figuring out if the above does apply, and if there is another way to grow both types. I have tested a few options of which none have successfully solved the issue. I do however plan to at least keep testing until I can provide proper result.

Arthri commented 3 years ago

I see. Good luck on that! I just wanted to say no rush though. I'm not using /grow for something right now but I figured I'd point it out.

No rush, and thanks!