search

Pryaxis / TShock

☕️⚡️TShock provides Terraria servers with server-side characters, anti-cheat, and community management tools.
GNU General Public License v3.0
2.41k stars 377 forks source link

Ice Rod doesn't work if player switches out from Ice Rod #2378

Open Arthri opened 3 years ago

Arthri commented 3 years ago

Reproduction steps (if applicable)?

  1. Use ice rod
  2. Switch to another item before it's placed
  3. Ice rod block disappears

Any stack traces or error messages (if known)?

N/A

Any screenshots?

https://user-images.githubusercontent.com/41360489/123409564-e4073400-d5e0-11eb-81a7-eab8c4bd54ee.mp4

Any log messages from files that end in .log or .txt? What are the last 100 log messages from the server console?

2021-06-25 18:07:38 - <>c: INFO: Port overridden by startup argument. Set to 7777
2021-06-25 18:07:38 - TextLog: INFO: TShock 4.5.4.0 (Blood Moon edition) now running.
2021-06-25 18:07:38 - TShock: INFO: AutoSave Enabled
2021-06-25 18:07:38 - TShock: INFO: Backups Disabled
2021-06-25 18:07:38 - TShock: INFO: Welcome to TShock for Terraria!
2021-06-25 18:07:38 - TShock: INFO: TShock comes with no warranty & is free software.
2021-06-25 18:07:38 - TShock: INFO: You can modify & distribute it under the terms of the GNU GPLv3.
2021-06-25 18:07:42 - TShock: INFO: Login before join enabled. Users may be prompted for an account specific password instead of a server password on connect.
2021-06-25 18:07:42 - TShock: INFO: Login using UUID enabled. Users automatically login via UUID.
2021-06-25 18:07:42 - TShock: INFO: A malicious server can easily steal a user's UUID. You may consider turning this option off if you run a public server.
2021-06-25 18:07:42 - TextLog: VERBOSE: GetDataHandlers / HandlePlayerBuffList handled event and sent data Test1
2021-06-25 18:07:42 - GetDataHandlers: INFO: Test1 authenticated successfully as user Test1.
2021-06-25 18:07:44 - TShock: INFO: Test1 (127.0.0.1) from 'default' group joined. (1/2)
2021-06-25 18:07:44 - Utils: INFO: Broadcast: Test1 has joined.
2021-06-25 18:07:44 - TextLog: VERBOSE: Bouncer / OnPlayerBuff rejected hostile/pvp from Test1
2021-06-25 18:07:44 - TextLog: VERBOSE: GetDataHandlers / HandlePlayerBuffList handled event and sent data Test1
2021-06-25 18:07:45 - TextLog: VERBOSE: Bouncer / OnPlayerBuff rejected hostile/pvp from Test1
2021-06-25 18:07:45 - TextLog: VERBOSE: GetDataHandlers / HandlePlayerBuffList handled event and sent data Test1
2021-06-25 18:07:47 - TextLog: VERBOSE: Bouncer / OnNewProjectile please report to tshock about this! normally this is a reject from Test1 80
2021-06-25 18:07:47 - TextLog: VERBOSE: Bouncer / OnTileEdit rejected from tile placement not matching selected item createTile Test1 PlaceTile 127 selectedItemID:911 createTile:208
2021-06-25 18:07:47 - TextLog: VERBOSE: Bouncer / OnNewProjectile please report to tshock about this! normally this is a reject from Test1 80
2021-06-25 18:07:49 - TextLog: VERBOSE: Bouncer / OnNewProjectile please report to tshock about this! normally this is a reject from Test1 80
2021-06-25 18:07:49 - TextLog: VERBOSE: Bouncer / OnTileEdit rejected from tile placement not matching selected item createTile Test1 PlaceTile 127 selectedItemID:911 createTile:208
2021-06-25 18:07:49 - TextLog: VERBOSE: Bouncer / OnNewProjectile please report to tshock about this! normally this is a reject from Test1 80
2021-06-25 18:07:50 - TextLog: VERBOSE: Bouncer / OnNewProjectile please report to tshock about this! normally this is a reject from Test1 80
2021-06-25 18:07:50 - TextLog: VERBOSE: Bouncer / OnTileEdit rejected from tile placement not matching selected item createTile Test1 PlaceTile 127 selectedItemID:911 createTile:208
2021-06-25 18:07:50 - TextLog: VERBOSE: Bouncer / OnNewProjectile please report to tshock about this! normally this is a reject from Test1 80
2021-06-25 18:07:52 - TextLog: VERBOSE: Bouncer / OnNewProjectile please report to tshock about this! normally this is a reject from Test1 80
2021-06-25 18:07:52 - TextLog: VERBOSE: Bouncer / OnNewProjectile please report to tshock about this! normally this is a reject from Test1 80
2021-06-25 18:07:53 - TextLog: VERBOSE: Bouncer / OnNewProjectile please report to tshock about this! normally this is a reject from Test1 80
2021-06-25 18:07:53 - TextLog: VERBOSE: Bouncer / OnTileEdit rejected from tile placement not matching selected item createTile Test1 PlaceTile 127 selectedItemID:9 createTile:30
2021-06-25 18:07:53 - TextLog: VERBOSE: Bouncer / OnNewProjectile please report to tshock about this! normally this is a reject from Test1 80
2021-06-25 18:07:59 - Utils: INFO: Server executed: /exit.
2021-06-25 18:07:59 - Utils: INFO: Broadcast: Saving world...
2021-06-25 18:07:59 - Utils: INFO: Broadcast: World saved.
2021-06-25 18:07:59 - SaveManager: INFO: World saved at (C:\Users\REDACTED\Documents\My Games\Terraria\Worlds\Test2.wld)
2021-06-25 18:07:59 - Utils: INFO: Broadcast: Server shutting down!
2021-06-25 18:07:59 - Utils: INFO: Broadcast: Server shutting d2021-06-25 18:07:59 - TShock: INFO: Test1 disconnected.
2021-06-25 18:07:59 - Utils: INFO: Broadcast: Saving world...
2021-06-25 18:08:00 - Utils: INFO: Broadcast: World saved.
2021-06-25 18:08:00 - SaveManager: INFO: World saved at (C:\Users\REDACTED\Documents\My Games\Terraria\Worlds\Test2.wld)

What plugins and what versions of those plugins are you running?

TShock 4.5.4

moisterrific commented 3 years ago

I think it's caused by the way ice rod/temp ice tile check is made. Maybe changing it to a time based check (time since player last held/used ice rod) will fix it.