search

Pryaxis / TShock

☕️⚡️TShock provides Terraria servers with server-side characters, anti-cheat, and community management tools.
GNU General Public License v3.0
2.43k stars 382 forks source link

[Request & Mobile Support] .NET 5 Support #2457

Closed EMREOYUN closed 2 years ago

EMREOYUN commented 3 years ago

DeathCradle/Open-Terraria-API has a upcoming branch that can build a working OTAPI from Vanilla Mobile Server(and PC Vanilla Server too). The problem is, OTAPI builds on .NET 5. Since TShock works on .NET 4.5, this OTAPI can not be integrated neither TerrariaServerAPI and TShock.

My question is, can we somehow integrate it to existing code with some kind of upgrading or should we need code from scratch?

bartico6 commented 3 years ago

Can you integrate it - I don't know, probably? Should you - not sure, because iirc OTAPI3 would be the basis for Orion, a redesign of the server engine model, and I'm not sure TShock in its current state is going to be brought over (or even be compatible?).

Also, this is discussion material I think.

EMREOYUN commented 3 years ago

Can you integrate it - I don't know, probably? Should you - not sure, because iirc OTAPI3 would be the basis for Orion, a redesign of the server engine model, and I'm not sure TShock in its current state is going to be brought over (or even be compatible?).

Also, this is discussion material I think.

It seems i can't because OTAPI 3 does not contain OTAPI.Patcher.Engine object group.

AxeelAnder commented 3 years ago

ofc we can, it is not even a tough task

SignatureBeef commented 3 years ago

ofc we can, it is not even a tough task

i have poc upgrades to the existing stack (non mobile), or orion can be used instead. whatever the guys want to do, they can. https://github.com/DeathCradle/TShock/tree/otapi3 https://github.com/DeathCradle/TerrariaAPI-Server/tree/otapi3

mobile support is quite new, and likely would need tshock to opt in to use and support that package.

Should you - not sure, because iirc OTAPI3 would be the basis for Orion, a redesign of the server engine model, and I'm not sure TShock in its current state is going to be brought over (or even be compatible?).

all legacy hooks have an upgrade path.

SignatureBeef commented 2 years ago

update, .net6 support for pc exists now. otapi.mobile isn't currently planned for tshock integration, at least yet. there are plugins that can enable similar outcomes to this.

EMREOYUN commented 2 years ago

update, .net6 support for pc exists now. otapi.mobile isn't currently planned for tshock integration, at least yet. there are plugins that can enable similar outcomes to this.

Actually PC and Mobile are very similar now. No need to create different branches.