search

Pryaxis / TShock

☕️⚡️TShock provides Terraria servers with server-side characters, anti-cheat, and community management tools.
GNU General Public License v3.0
2.41k stars 377 forks source link

Fix player does't use the Shellphone (Ocean), Shellphone (Underworld)… #2703

Closed hufang360 closed 1 year ago

hufang360 commented 1 year ago

Fix player does't use the Shellphone (Ocean), Shellphone (Underworld) and Shellphone (Spawn).

AxisKriel commented 1 year ago

The changelog entry needs to follow the changelog guidelines (https://github.com/Pryaxis/TShock/blob/general-devel/CHANGELOG.md#how-to-add-a-changelog-entry). I suggest: Fixed players being unable to use Shellphone (Ocean), Shellphone (Underworld) and Shellphone (Spawn). (@hufang360)

Other than that, I tested the code changes and they work, looks good to me 👍

AxisKriel commented 1 year ago

CI is 👌 Now just needs @hakusaro seal of approval :)

hakusaro commented 1 year ago

@AxisKriel you can review these things too, ya know :p

hakusaro commented 1 year ago

Just so we're on the same page, y'all are clear on what this does? This blocks the shellphone if the user doesn't have permission. By default, it would let it through? I'm willing to approve it if y'all can re-confirm that this is the intent of the change.

hufang360 commented 1 year ago

Yes, that's right.

hakusaro commented 1 year ago

@hufang360 merged! thank you for your awesome work!

hakusaro commented 1 year ago

@AxisKriel fwiw,

The changelog entry needs to follow the changelog guidelines

This is generally true but it won't stop me from merging a PR if it can be easily corrected and the requestor is not a native English speaker. It's not worth nitpicking/dying on a hill for grammar usually. If it's easy to correct or understand it's nbd!