search

Pryaxis / TShock

☕️⚡️TShock provides Terraria servers with server-side characters, anti-cheat, and community management tools.
GNU General Public License v3.0
2.43k stars 381 forks source link

Update i18n #2760

Closed sgkoishi closed 2 years ago

sgkoishi commented 2 years ago

https://github.com/perpetualKid/GetText.NET/issues/44

Also some minor fixes pending

sgkoishi commented 2 years ago

There are still ~100 player.Send(Info|Warning|Error)Message("literal string") left.

hakusaro commented 2 years ago

Wow that was fast

hakusaro commented 2 years ago

This creates a few word puzzles -- I really wish you'd made separate commits because it would be easier to merge smaller chunks at a time. I'm happy to approve this but I think @pontaoski should review it before it gets merged.

The reason why I was going (quite slowly) through Commands.cs was to try to fix the English consistency too at the same time, since it's just one pass. This doesn't change the fact that English strings aren't consistent, and if anything, makes me feel like it's a lower priority (because I won't be able justify doing it as part of the i18n work).

Like, if we merge this now and then make English consistent the strings will definitely change in i18n land. The latest Crowdin PR also has the issue with Russian, which means we can't merge more translations anyway.

hakusaro commented 2 years ago

The main thing I'm worried about is word puzzles, the rest of the PR is ok!

hakusaro commented 2 years ago

I'm okay with this -- and I'm willing to say we should merge this -- but please avoid code formatting changes in bulk in future pull-requests like this. It's really a lot of lines to review already.