Pryaxis / TShock

☕️⚡️TShock provides Terraria servers with server-side characters, anti-cheat, and community management tools.
GNU General Public License v3.0
2.41k stars 377 forks source link

PVP with no team #2834

Closed ATFGK closed 1 year ago

ATFGK commented 1 year ago

resolved #2617

An additional option pvpwithnoteam is added at PvPMode to enable PVP with no team

drunderscore commented 1 year ago

It feels a bit weird to specify team properties in a configuration option named PvPMode... how about creating a new configuration option (such as TeamMode), with similar options to PvPMode, where:

That way all the existing options of PvPMode can be used alongside TeamMode in multiple configurations.

ATFGK commented 1 year ago

It feels a bit weird to specify team properties in a configuration option named ... how about creating a new configuration option (such as ), with similar options to , where:PvPMode``TeamMode``PvPMode

  • normal, which is the default, and does nothing
  • disabled, which prevents team switching
  • A team name, such as or , which forces players onto that teamred``blue

That way all the existing options of can be used alongside in multiple configurations.PvPMode``TeamMode

This idea seems good, but it doesn't seem to work because the same team will lose its PVP

sgkoishi commented 1 year ago

Would it be better to use permission to restrict team switch and pvp?

ATFGK commented 1 year ago

Would it be better to use permission to restrict team switch and pvp?

Maybe so.

sgkoishi commented 1 year ago

It's usually suggested to use another branch to merge unrelated changes since this branch is connected to a PR.

hakusaro commented 1 year ago

@ATFGK can you clean this PR up or at least point to the exact commit(s) you want merged so that we can potentially just cherry-pick the changes? Each PR tree should be an independent set of changes. This is really confusing and not likely something we can merge without significant cleanup of this branch.

ATFGK commented 1 year ago

@ATFGK can you clean this PR up or at least point to the exact commit(s) you want merged so that we can potentially just cherry-pick the changes? Each PR tree should be an independent set of changes. This is really confusing and not likely something we can merge without significant cleanup of this branch.

I will resend it.....