search

Pryaxis / TShock

☕️⚡️TShock provides Terraria servers with server-side characters, anti-cheat, and community management tools.
GNU General Public License v3.0
2.41k stars 377 forks source link

Update GetDataHandlers.cs #2852

Closed ATFGK closed 1 year ago

ATFGK commented 1 year ago

Fixes #2804

Fix GetDataHandlers.cs file for version 144X, and correct various errors caused by it.

drunderscore commented 1 year ago

As originally requested in #2823, please don't include changes to number of PVE/PVP deaths, as that will be dealt with in #2768

Commits and changes are still a bit scattered, and it's not super clear which issues this PR solves -- can you update the description to include the specific issues that this PR solves?

ATFGK commented 1 year ago

As originally requested in #2823, please don't include changes to number of PVE/PVP deaths, as that will be dealt with in #2768

Commits and changes are still a bit scattered, and it's not super clear which issues this PR solves -- can you update the description to include the specific issues that this PR solves?

1.Fixed wrong MaxProjDamage trigger. 2.Fix the wrong resurrection prompt. Once I delete the content related to PVE/PVP, the second problem will not be solved.

drunderscore commented 1 year ago

@ATFGK I'm not sure I understand that last issue -- can you describe it further or show an example?

ATFGK commented 1 year ago

@ATFGK I'm not sure I understand that last issue -- can you describe it further or show an example?

It has little impact on "Tshock", but the wrong "SpawnContext" message will cause a lot of problems for other plug-ins because they cannot correctly recognize "SpawnContext"

ATFGK commented 1 year ago

@ATFGK I'm not sure I understand that last issue -- can you describe it further or show an example?

It has little impact on "Tshock", but the wrong "SpawnContext" message will cause a lot of problems for other plug-ins because they cannot correctly recognize "SpawnContext"

"Tshock" also uses a lot of "TSPlayer. Spawn()", so other plug-ins cannot avoid receiving incorrect "SpawnContext"

drunderscore commented 1 year ago

Yeah, totally see the issue and understand. With that other PR blocked for non-working, I'm fine accepting these changes first, even if it means the other PR will get conflicts.

I'll review this ASAP.

drunderscore commented 1 year ago

To make it even easier, I've created a pull request on your repository for this branch with the correct changes.

ATFGK commented 1 year ago

To make it even easier, I've created a pull request on your repository for this branch with the correct changes.

Thank you very much for your help. :-D