Pryaxis / TShock

☕️⚡️TShock provides Terraria servers with server-side characters, anti-cheat, and community management tools.
GNU General Public License v3.0
2.41k stars 377 forks source link

Players can turn campfires on and off even if the campfire is in a protected region #2905

Open ZakFahey opened 1 year ago

ZakFahey commented 1 year ago

Reproduction steps (if applicable)?

  1. Place a campfire inside a protected region
  2. As a non-privileged user, try to switch the campfire on or off

Any stack traces or error messages (if known)?

No

Any screenshots?

N/A

Any log messages from files that end in .log or .txt? What are the last 100 log messages from the server console?

Debug: GetDataHandlers / HandlePlayerBuffList handled event and sent data t e s t
Debug: GetDataHandlers / HandlePlayerBuffList handled event and sent data t e s t
Debug: GetDataHandlers / HandlePlayerBuffList handled event and sent data t e s t
Debug: GetDataHandlers / HandlePlayerBuffList handled event and sent data t e s t
Debug: GetDataHandlers / HandlePlayerBuffList handled event and sent data t e s t
Debug: GetDataHandlers / HandlePlayerBuffList handled event and sent data t e s t
Debug: GetDataHandlers / HandlePlayerBuffList handled event and sent data t e s t
Debug: GetDataHandlers / HandlePlayerBuffList handled event and sent data t e s t
Debug: GetDataHandlers / HandlePlayerBuffList handled event and sent data t e s t
reload

This is the logs I captured, but the player "t e s t" was not setting the campfire. I didn't see any logs that were logged that were actually relevant to the problem.

What plugins and what versions of those plugins are you running?

For all plugins, I have the latest version

If I didn't provide any logs this issue, please close my issue immediately. I'm sorry for the inconvenience.

sgkoishi commented 1 year ago

Can you try leave the server and re-join to see if it's actually toggled?

ZakFahey commented 1 year ago

Yes, it stays toggled when you leave and rejoin the server.

sgkoishi commented 1 year ago

Unable to reproduce. I tested the spawn and a protected region, and both were rejected as expected. Are you sure the region is protected and the player has no privilege?

ghost commented 11 months ago

@ZakFahey please test it on this server program before creating an issue on this repository... make a issue on the FORK