search

Pryaxis / TShock

☕️⚡️TShock provides Terraria servers with server-side characters, anti-cheat, and community management tools.
GNU General Public License v3.0
2.42k stars 378 forks source link

/gbuff is sending message to wrong user #2954

Closed Arthri closed 1 year ago

Arthri commented 1 year ago

Reproduction steps (if applicable)?

  1. /gbuff otherplayer Honey
  2. No success message is sent to the user

Any stack traces or error messages (if known)?

N/A

Any screenshots?

https://github.com/Pryaxis/TShock/assets/41360489/597071b9-2084-4f22-b6b8-6af15d9ae4f8

https://github.com/Pryaxis/TShock/blob/72ecc472187dde708ea2a2d1176e3b9872cd27f7/TShockAPI/Commands.cs#L6465

Any log messages from files that end in .log or .txt? What are the last 100 log messages from the server console?

[06/11/23 06:42:20] [Server API] Verbose: TerrariaApi - Server v2.1.0.0 started.
[06/11/23 06:42:20] [Server API] Verbose:   Command line: "D:\TShock.Server.exe" -config serverconfig.txt
[06/11/23 06:42:20] [Server API] Verbose:   OS: Microsoft Windows NT 10.0.0.0 (64bit: True)
[06/11/23 06:42:20] [Server API] Verbose:   Mono: False
[06/11/23 06:42:20] [TShock] Verbose: Loading dedicated config file: serverconfig.txt
[06/11/23 06:42:20] [Server API] Info: Plugin TShock v5.2.0.0 (by The TShock Team) initiated.
2023-06-11 06:42:20 - TShock: INFO: TShock 5.2.0.0 (Intensity) now running.
2023-06-11 06:42:20 - TShock: INFO: AutoSave Enabled
2023-06-11 06:42:20 - TShock: INFO: Backups Enabled
2023-06-11 06:42:20 - TShock: INFO: Welcome to TShock for Terraria!
2023-06-11 06:42:20 - TShock: INFO: TShock comes with no warranty & is free software.
2023-06-11 06:42:20 - TShock: INFO: You can modify & distribute it under the terms of the GNU GPLv3.
2023-06-11 06:42:25 - TShock: INFO: Login before join enabled. Users may be prompted for an account specific password instead of a server password on connect.
2023-06-11 06:42:25 - TShock: INFO: Login using UUID enabled. Users automatically login via UUID.
2023-06-11 06:42:25 - TShock: INFO: A malicious server can easily steal a user's UUID. You may consider turning this option off if you run a public server.
2023-06-11 06:42:26 - GetDataHandlers: INFO: Test1 authenticated successfully as user Test1.
2023-06-11 06:42:27 - TShock: INFO: Test1 (127.0.0.1) from 'superadmin' group joined. (1/8)
2023-06-11 06:42:27 - Utils: INFO: Broadcast: Test1 has joined.
2023-06-11 06:42:28 - TShock: INFO: Test2 (127.0.0.1) from 'guest' group joined. (2/8)
2023-06-11 06:42:28 - Utils: INFO: Broadcast: Test2 has joined.
2023-06-11 06:43:20 - Utils: INFO: Test1 executed: /gbuff test2 Honey.
2023-06-11 06:43:29 - Utils: INFO: Broadcast: Test1 has left.
2023-06-11 06:43:29 - TShock: INFO: Test1 disconnected.
2023-06-11 06:43:32 - Utils: INFO: Broadcast: Test2 has left.
2023-06-11 06:43:32 - TShock: INFO: Test2 disconnected.
2023-06-11 06:43:32 - Utils: INFO: Broadcast: Saving world...
2023-06-11 06:43:33 - Utils: INFO: Broadcast: World saved.
2023-06-11 06:43:33 - SaveManager: INFO: World saved at (C:\Users\USER\Documents\My Games\Terraria\Worlds\PluginTestWorld.wld)
2023-06-11 06:43:35 - Utils: INFO: Server executed: /exit.
2023-06-11 06:43:35 - Utils: INFO: Broadcast: Saving world...
2023-06-11 06:43:35 - Utils: INFO: Broadcast: World saved.
2023-06-11 06:43:35 - SaveManager: INFO: World saved at (C:\Users\USER\Documents\My Games\Terraria\Worlds\PluginTestWorld.wld)
2023-06-11 06:43:35 - Utils: INFO: Broadcast: Server shutting down!
2023-06-11 06:43:35 - Utils: INFO: Broadcast: Saving world...

What plugins and what versions of those plugins are you running?

TShockAPI

sgkoishi commented 1 year ago

git blame shows... well