search

Pryaxis / TShock

☕️⚡️TShock provides Terraria servers with server-side characters, anti-cheat, and community management tools.
GNU General Public License v3.0
2.39k stars 374 forks source link

Add CI for Docker images #2974

Closed timschumi closed 3 months ago

timschumi commented 9 months ago

This doesn't push the image anywhere, it just makes sure that the Docker build works.

Note that this removes the recommendation to use docker build even for native builds, since users would now have to set both TARGETPLATFORM and BUILDPLATFORM manually. docker buildx is available since Docker engine 19.03, which has been released in late 2019, so it isn't as bleeding-edge as it once was and more widely available now.

timschumi commented 9 months ago

Depends on #2971, since that unbreaks the docker build in the first place.

timschumi commented 7 months ago

Bump? :^)

timschumi commented 5 months ago

@hakusaro Any chance that we can get this reapproved and pulled in?

koalalorenzo commented 3 months ago

Any update on this ? :) @hakusaro @timschumi ?

timschumi commented 3 months ago

Any update on this ? :) @hakusaro @timschumi ?

I think I did all that I could do, now it's just waiting on someone to merge it. After all, the PR was already approved once before.