search

Pryaxis / TShock

☕️⚡️TShock provides Terraria servers with server-side characters, anti-cheat, and community management tools.
GNU General Public License v3.0
2.39k stars 374 forks source link

Fixed typo in ProjectileManager #2988

Closed RenderBr closed 5 months ago

RenderBr commented 8 months ago

This is a very simple pull request. I have simply bulk renamed the class that was originally ProjectileManagager to ProjectileManager. This is minor, but I felt like it should be done.

hakusaro commented 8 months ago

Won’t this break any third party consumers of the ProjectileManagager?

drunderscore commented 8 months ago

Yeah, this is both source and binary incompatible, can't rename it. If it bothers you enough, I suppose this will have to do:

using ProjectileManager = ProjectileManagager;
RenderBr commented 8 months ago

Fair enough, I didn't think about this. Feel free to close this PR.

lucasgames8957 commented 8 months ago

@RenderBr if you wish to close this then close the PR with the close button

Arthri commented 8 months ago

For the record, I'm not against this PR, but it'll have to be delayed until the next major update to prevent unnecessary breaking changes in between feature versions

lucasgames8957 commented 8 months ago

guess this is a major update thing...