Pryaxis / TShock

☕️⚡️TShock provides Terraria servers with server-side characters, anti-cheat, and community management tools.
GNU General Public License v3.0
2.42k stars 378 forks source link

Rewrite: Partially fix bed spawning for SSC #3031

Open PotatoCider opened 4 months ago

PotatoCider commented 4 months ago

This PR rewrites the player spawnpoint saving system for SSC.

When SSC is enabled, player spawnpoints are only saved server side but not client side. However, due to the game's netcode logic, it is most likely impossible for the server (TShock) to change the client's spawnpoint value Terraria.Player.Spawn{X,Y} since the server provided value gets overwritten by its own client sided spawnpoint value in sp{X,Y} in Terraria.Player.FindSpawn() after packet 12 has been received.

In order to workaround this, TShock would keep track of the client's initial spawnpoint value on the first player spawn, it uses this value to compare if the player has changed his spawnpoint. This way, we can teleport the player with the correct server saved spawnpoint after the player tries to spawn with its incorrect client sided spawnpoint, at least before the player changes his spawnpoint mid-game.

What this means is that we purposely desync the client and server Terraria.Player.Spawn{X,Y} value before we know that the player had changed his spawnpoint. Once we know its changed, both client and server spawnpoint values would be synced, and we won't need to force teleport the player anymore.

Note that there is one limitation with this approach - this only works if the player spawns at his changed spawnpoint before logging off, otherwise the server would have no idea that the player's spawnpoint has changed.

I'm not sure if I covered all test cases, but please let me know if there is any bugs :)

hakusaro commented 4 months ago

What problem are you trying to solve here?

PotatoCider commented 4 months ago

What problem are you trying to solve here?

I'm mainly trying to solve #1966 (and #2844, #3011) which were known issues for quite some time. This PR doesn't fully solve the bed spawning problem with the limitations above. There are also other related issues like #1849.