search

Pryaxis / TShock

☕️⚡️TShock provides Terraria servers with server-side characters, anti-cheat, and community management tools.
GNU General Public License v3.0
2.43k stars 382 forks source link

Remove IP column in database #495

Closed hakusaro closed 11 years ago

hakusaro commented 11 years ago

We deprecated IP users ages ago, and now we have a blank column for IP users in the database. Removing this would simplify administration for admins and add clarity to the database. Would really work well once #479 is done.

hakusaro commented 11 years ago

Okay, so the issue with removing this feature is that we will break reserved slots. @Olink, I don't know if we want to just let players offload that to a plugin? I'm already hacking on this on a non-pushed separate branch, but I don't want to cause issues later.

So I guess, the real question is, do we remove all of the IP address user capabilities, including reserved slots?

hakusaro commented 11 years ago

Let me clarify myself again. Apparently whitelist.txt is how that feature works, so I'm going to remove IP users again.

Olink commented 11 years ago

doesnt loginbeforjoin handle reserved slots?

hakusaro commented 11 years ago

Yeah. Didn't remember.

Lucas Nicodemus via Google Nexus 4 On Aug 23, 2013 4:57 AM, "Zack" notifications@github.com wrote:

doesnt loginbeforjoin handle reserved slots?

— Reply to this email directly or view it on GitHubhttps://github.com/TShock/TShock/issues/495#issuecomment-23156686 .

Olink commented 11 years ago

Whitelist also shouldnt control reserved slots, whitelist just blocks anyone from joining who isnt on it.

hakusaro commented 11 years ago

It was late at night.

Remove reserved slots and let a plugin do it or move it to a file, then?

Lucas Nicodemus via Google Nexus 4 On Aug 23, 2013 6:48 AM, "Zack" notifications@github.com wrote:

Whitelist also shouldnt control reserved slots, whitelist just blocks anyone from joining who isnt on it.

— Reply to this email directly or view it on GitHubhttps://github.com/TShock/TShock/issues/495#issuecomment-23161298 .

Olink commented 11 years ago

again, i think reserved slots still work, but i cant be certain, it has been a while since ive looked at zido's code.

Olink commented 11 years ago

Having looked through the usage of the IP address in TShock, the only real usage is to allow logging in via ip, which is pointless now that we have 'login before join' and user accounts. Ill make a new pull request, hopefully fixing the issues that we saw on @nicatronTg's pr.

hakusaro commented 11 years ago

@Olink there is actually another problem: the REST api supports creating IP users too.

hakusaro commented 11 years ago

(Or at least, according to the wiki it does)

Olink commented 11 years ago

not anymore.

hakusaro commented 11 years ago

Cool.