Pryaxis / TShock

☕️⚡️TShock provides Terraria servers with server-side characters, anti-cheat, and community management tools.
GNU General Public License v3.0
2.43k stars 382 forks source link

If you die before you login you lose your character #511

Closed d3x7ro closed 11 years ago

d3x7ro commented 11 years ago

If you die before you /login you lose your character on hardcore.

{
  "InvasionMultiplier": 1,
  "DefaultMaximumSpawns": 5,
  "DefaultSpawnRate": 600,
  "ServerPort": 7777,
  "EnableWhitelist": false,
  "InfiniteInvasion": false,
  "PvPMode": "disabled",
  "SpawnProtection": true,
  "SpawnProtectionRadius": 50,
  "MaxSlots": 100,
  "RangeChecks": true,
  "DisableBuild": false,
  "SuperAdminChatRGB": [
    244.0,
    27.0,
    93.0
  ],
  "SuperAdminChatPrefix": "[A] ",
  "SuperAdminChatSuffix": "",
  "BackupInterval": 60,
  "BackupKeepFor": 6000,
  "RememberLeavePos": false,
  "HardcoreOnly": true,
  "MediumcoreOnly": false,
  "KickOnMediumcoreDeath": false,
  "BanOnMediumcoreDeath": false,
  "AutoSave": true,
  "MaximumLoginAttempts": 3,
  "RconPassword": "",
  "RconPort": 7777,
  "ServerName": "HT",
  "UseServerName": false,
  "MasterServer": "127.0.0.1",
  "StorageType": "sqlite",
  "MySqlHost": "localhost:3306",
  "MySqlDbName": "",
  "MySqlUsername": "",
  "MySqlPassword": "",
  "MediumcoreBanReason": "Death results in a ban",
  "MediumcoreKickReason": "Death results in a kick",
  "EnableDNSHostResolution": false,
  "EnableIPBans": true,
  "EnableBanOnUsernames": false,
  "DefaultRegistrationGroupName": "default",
  "DefaultGuestGroupName": "guest",
  "DisableSpewLogs": true,
  "HashAlgorithm": "sha512",
  "BufferPackets": true,
  "ServerFullReason": "Server is full.",
  "WhitelistKickReason": "You are not on the whitelist.",
  "ServerFullNoReservedReason": "Server is full. No reserved slots open.",
  "SaveWorldOnCrash": true,
  "EnableGeoIP": false,
  "EnableTokenEndpointAuthentication": false,
  "ServerNickname": "HT",
  "RestApiEnabled": false,
  "RestApiPort": 7878,
  "DisableTombstones": true,
  "DisplayIPToAdmins": true,
  "EnableInsecureTileFixes": true,
  "KickProxyUsers": true,
  "DisableHardmode": false,
  "DisableDungeonGuardian": false,
  "ServerSideInventory": true,
  "ServerSideInventorySave": 15,
  "LogonDiscardThreshold": 1000,
  "DisablePlayerCountReporting": true,
  "DisableClownBombs": false,
  "DisableSnowBalls": false,
  "ChatFormat": "[{0}] {1}{2}{3}: {4}",
  "ChatAboveHeadsFormat": "{4}",
  "ForceTime": "normal",
  "TileKillThreshold": 60,
  "TilePlaceThreshold": 20,
  "TileLiquidThreshold": 15,
  "ProjectileThreshold": 50,
  "ProjIgnoreShrapnel": true,
  "RequireLogin": true,
  "DisableInvisPvP": false,
  "MaxRangeForDisabled": 10,
  "ServerPassword": "",
  "RegionProtectChests": false,
  "DisableLoginBeforeJoin": true,
  "AllowRegisterAnyUsername": true,
  "AllowLoginAnyUsername": true,
  "MaxDamage": 175,
  "MaxProjDamage": 175,
  "IgnoreProjUpdate": false,
  "IgnoreProjKill": false,
  "IgnoreNoClip": false,
  "AllowIce": false,
  "AllowCorruptionCreep": true,
  "AllowHallowCreep": true,
  "StatueSpawn200": 3,
  "StatueSpawn600": 6,
  "StatueSpawnWorld": 10,
  "PreventBannedItemSpawn": false,
  "DisablePiggybanksOnSSI": false,
  "PreventDeadModification": false,
  "EnableChatAboveHeads": true,
  "HideStatTrackerDebugMessages": true,
  "ForceXmas": false,
  "AllowAllowedGroupsToSpawnBannedItems": false
}
cheahjs commented 11 years ago

Character deletion is handled client side, nothing we can do on the server end.

d3x7ro commented 11 years ago

Don't let them take damage until they login? Heal them like crazy until they login? The way its setup they can die before they login and continue to play for hours not even knowing they have lost their character and even worse none of it will be saved.

Olink commented 11 years ago

Character health is done client side, why should we ensure they login before dying?

hakusaro commented 11 years ago

How*

Lucas Nicodemus via Google Nexus 4 On Aug 15, 2013 6:17 AM, "Zack" notifications@github.com wrote:

Character health is done client side, why should we ensure they login before dying?

— Reply to this email directly or view it on GitHubhttps://github.com/TShock/TShock/issues/511#issuecomment-22699508 .

Olink commented 11 years ago

I don't even understand what the problem is...

They lose their character?

Thats what hardcore mode is, when you die, your character drops everything. What does logging in have to do with that? Do you think we do something fancy for when they die in hardcore mode like virtually save their items?

hakusaro commented 11 years ago

I guess maybe if they can't affect the world, but it can affect them, they shouldn't really die in hardcore until after they can affect the server - but I don't see how we can do anything here...I'm lost.

Lucas Nicodemus via Web

On Thu, Aug 15, 2013 at 8:52 AM, Zack notifications@github.com wrote:

I don't even understand what the problem is... They lose their character? Thats what hardcore mode is, when you die, your character drops everything. What does logging in have to do with that? Do you think we do something fancy for when they die in hardcore mode like virtually save their items?

— Reply to this email directly or view it on GitHubhttps://github.com/TShock/TShock/issues/511#issuecomment-22707861 .

Olink commented 11 years ago

In that case, why not just force login before join, and done.

d3x7ro commented 11 years ago

Character health is done client side, why should we ensure they login before dying?

I don't even understand what the problem is...

You disable and debuff them so they cant do anything about attackers.

In that case, why not just force login before join, and done.

What if there username is different from their character name? or new users don't understand the server doesn't actually have a password and just go elsewhere?

Olink commented 11 years ago

You still havent told us why you need this...we don't understand the issue. You want us to protect your players from your other players?

The features you are looking for will never go into tshock, you want a plugin that protects your slow typing players from pvp whores.

hakusaro commented 11 years ago

Isn't there a config option that already exists that disables/debuffs you if you aren't logged in? I could see that being added if it doesn't exist already, but it could easily, very easily be a plugin instead.

Lucas Nicodemus via Web

On Thu, Aug 15, 2013 at 12:00 PM, Zack notifications@github.com wrote:

You still havent told us why you need this...we don't understand the issue. You want us to protect your players from your other players?

The features you are looking for will never go into tshock, you want a plugin that protects your slow typing players from pvp whores.

— Reply to this email directly or view it on GitHubhttps://github.com/TShock/TShock/issues/511#issuecomment-22717918 .

Olink commented 11 years ago

@nicatronTg You misunderstood his statement. He is accusing us of debuffing and disabling his players and thus rendering them incapable of typing login since they are being killed as soon as they join. Sounds like he has a poor server spawn and new players get trolled.

Turning off requirelogin would stop them from being disabled/debuffed so they can run away before logging in or w/e tickles their fancy. I still think 5 minutes on the forums would have yielded a suitable solution that wouldn't require us to harass you about this. When someone reports a bug, we have to grill them.

d3x7ro commented 11 years ago

turning off requirelogin doesn't dampen ssi?

hakusaro commented 11 years ago

@Olink, oh. Okay then.

Lucas Nicodemus via Web

On Thu, Aug 15, 2013 at 4:04 PM, d3x7ro notifications@github.com wrote:

turning off requirelogin doesn't dampen ssi?

— Reply to this email directly or view it on GitHubhttps://github.com/TShock/TShock/issues/511#issuecomment-22734231 .