Pryaxis / TShock

☕️⚡️TShock provides Terraria servers with server-side characters, anti-cheat, and community management tools.
GNU General Public License v3.0
2.41k stars 377 forks source link

Clear (items) does not work #633

Closed kalekip1 closed 10 years ago

kalekip1 commented 10 years ago

TShock version: 4.2.0.930

Command: /clear

Issue: Clearing items does not take work. Whether using a range (e.g. 321314), or using "all", it clears 0 items.

Additional notes: Not using any plugins. Using MySQL instead of SQLite.

Visual details

MarioE commented 10 years ago

Have you tried using it in-game?

kalekip1 commented 10 years ago

Yes, I have. Multiple times actually.

Hmm, very weird. Sometimes it works. Hopefully the video will help: http://www.youtube.com/watch?v=cHFvW7OwDPk

/clear all - fails /clear all - fails /clear 3000 - fails /clear 5000 - works /clear 7000 - fails(?) /clear - works /clear all - fails /clear - works

MarioE commented 10 years ago

It was probably an integer overflow issue I overlooked. Either way, this is no longer a concern as the command is now /clear items <range> in the latest build, which uses floats.

k0rd commented 10 years ago

Closing this for now - @kalekip1 please reopen this issue if the next pre - release (it will be 14) doesn't work as expected in this regard. (it looks like @MarioE has fixed this unwittingly though)