search

Pryaxis / TShock

☕️⚡️TShock provides Terraria servers with server-side characters, anti-cheat, and community management tools.
GNU General Public License v3.0
2.43k stars 382 forks source link

server doesnt detect mono #831

Closed marvinlehmann closed 10 years ago

marvinlehmann commented 10 years ago

My server running on Ubuntu precise (12.04.4 LTS) doesnt detect if its running on mono. ServerLog.txt: [07.31.14 11:24:05] [Server API] Verbose: TerrariaApi - Server v1.16.0.0 started. [07.31.14 11:24:05] [Server API] Verbose: Command line: /home/marvin/terraria_server/TerrariaServer.exe -world Terraria/Worlds/Lordran.wld -config tshock/config.json tshock/config.json -killinactivesocket [07.31.14 11:24:05] [Server API] Verbose: OS: Unix 3.2.0.32 (64bit: True) [07.31.14 11:24:05] [Server API] Verbose: Mono: False [07.31.14 11:24:05] [Server API] Verbose: World set for auto loading: Terraria/Worlds/Lordran.wld [07.31.14 11:24:05] [Server API] Verbose: Loading dedicated config file: tshock/config.json [07.31.14 11:24:05] [Server API] Info: Plugin TShock v4.2.3.720 (by The Nyx Team) initiated.

my start command line: mono-sgen /home/marvin/terraria_server/TerrariaServer.exe -world "Terraria/Worlds/Lordran.wld" -config "tshock/config.json" "tshock/config.json" -killinactivesocket

https://github.com/Deathmax/TerrariaAPI-Server/blob/a44d46af2f7b54110707b6f09875fdcf32365544/Terraria/Main.cs#L1972-L1973

https://github.com/Deathmax/TerrariaAPI-Server/blob/a44d46af2f7b54110707b6f09875fdcf32365544/TerrariaApi.Server/ServerApi.cs#L77

marvinlehmann commented 10 years ago

why was it closed?

hakusaro commented 10 years ago

If you don't start it with mono-sgen, does it correctly report a mono version?

marvinlehmann commented 10 years ago

There isn't a difference when I start my server with mono or mono-sgen. It says: false. I'm not a coding pro but https://github.com/Deathmax/TerrariaAPI-Server/blob/a44d46af2f7b54110707b6f09875fdcf32365544/TerrariaApi.Server/ServerApi.cs#L77 will be executed earlier than https://github.com/Deathmax/TerrariaAPI-Server/blob/a44d46af2f7b54110707b6f09875fdcf32365544/Terraria/Main.cs#L1972-L1973 . The default value is false (public static bool runningMono = false;) and when it doesnt get changed, it is logically that it logs "false". But what is then the reason of this mono log entry?

Can anyone confirm it to me please? =)

Olink commented 10 years ago

I closed it because its not an issue. Does your server work with mono? Yes. Thus no problem.

There is an issue in the software where we write monos value before checking if the system is in mono. If you want to fix it, go for it.

hakusaro commented 10 years ago

Oh, that works.

Lucas Nicodemus

On Thu, Jul 31, 2014 at 10:04 AM, Zack notifications@github.com wrote:

I closed it because its not an issue. Does your server work with mono? Yes. Thus no problem.

There is an issue in the software where we write monos value before checking if the system is in mono. If you want to fix it, go for it.

— Reply to this email directly or view it on GitHub https://github.com/NyxStudios/TShock/issues/831#issuecomment-50780081.