search

Pryaxis / TShock

☕️⚡️TShock provides Terraria servers with server-side characters, anti-cheat, and community management tools.
GNU General Public License v3.0
2.43k stars 382 forks source link

When it rains the screen doesn't show rain #949

Closed Puremin0rez closed 9 years ago

Puremin0rez commented 9 years ago

When it rains, all of the effects of rain occurs (flying fish, umbrella mobs, etc) but the rain isn't visible on screen.

tShock PR2 on Mono 4.0.2

tylerjwatson commented 9 years ago

As part of TSAPI I did remove references to rain, I might have mistakenly assumed it was just client code. May have to add it back

tylerjwatson commented 9 years ago

cc @WhiteXZ do you know of any way that we can turn rain on in the code to test whether this was the case?

QuiCM commented 9 years ago

@tylerjwatson link me the commit and I'll see if I can find any deleted code that may have been relevant

tylerjwatson commented 9 years ago

commit https://github.com/NyxStudios/TerrariaAPI-Server/commit/621781ea81a3be1bc657d7e4cf065a695c13d829

QuiCM commented 9 years ago

I can see no reason why that commit would break rain on the client end

tylerjwatson commented 9 years ago

yeah that's what I thought, is there any cases where rain is communicated in a packet anywhere? couldn't see any from the doc

QuiCM commented 9 years ago

@Puremin0rez can you reproduce this without TShock (i.e., just the terrariaserver build we provide)?

Puremin0rez commented 9 years ago

I'll go ahead and try it now. Might be a bit before I can get rain to trigger

Puremin0rez commented 9 years ago

Left the decompiled server (no tshock or server plugins active) running overnight and 3 people said the rain still was not visible on screen, but all effects were in place.

QuiCM commented 9 years ago

This is likely because our WorldInfo packet doesn't work as it should. If you leave then rejoin after it starts raining, you client should(?) start displaying the rain

QuiCM commented 9 years ago

Fixed in latest commit