search

Pryaxis / orion-core

The next generation Terraria Server API.
https://pryaxis.github.io/orion-core
GNU General Public License v3.0
31 stars 12 forks source link

Separate out implementations into launcher #73

Closed kevzhao2 closed 4 years ago

kevzhao2 commented 4 years ago

We need to separate out the implementations of the interfaces such as IItem, etc. into the launcher.

This allows Orion.Core to only be a set of APIs, and the concrete, Terraria-facing stuff gets put into the launcher.

hakusaro commented 4 years ago

Based on that last sentence, Launcher seems like a really odd choice of words. Can you elaborate more on that? On Fri, Jun 19, 2020 at 11:39 PM GitHub notifications@github.com wrote: “We need to separate out the implementations of the interfaces such as IItem, etc. into the launcher.

This allows Orion.Core to only be a set of APIs, and the concrete, Terraria-facing stuff gets put into the launcher.”

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

kevzhao2 commented 4 years ago

It's the entire set of things which will be required to launch an Orion instance.

So this means that implementations, like OrionItem, will be done in the "launcher". (There'll be corresponding tests in that, as well). Not sure if there's a better way to name this?

Basically, I don't want to expose OTAPI/Terraria from Orion.Core.

hakusaro commented 4 years ago

I’m not sure, but I’ll tell you that “Launcher” makes me think of like the Minecraft launcher and not a set of APIs, if that makes sense. On Fri, Jun 19, 2020 at 11:53 PM GitHub notifications@github.com wrote: “It's the entire set of things which will be required to launch an Orion instance.

So this means that implementations, like OrionItem, will be done in the "launcher". (There'll be corresponding tests in that, as well). Not sure if there's a better way to name this?

Basically, I don't want to expose OTAPI/Terraria from Orion.Core.”

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

kevzhao2 commented 4 years ago

I'll go with the launcher terminology for now. It should be fairly easy to rename in the future.

For the record, the launcher doesn't provide any APIs for consumption.