search

PrzypisPowszechny / pp-client

7 stars 2 forks source link

Annotation list in popup #275

Closed kaglowka closed 5 years ago

kaglowka commented 5 years ago

To be merged only after #274

Resolves #98 (out of the box). When the website content script is inactive, the popup now informs the user that the website is not supported. It's brutal, but also very effective. We can freely extend website blacklist in the extension manifest and the popup will pick it up, that the website does not cooperate with it.

Suggested follow-up:

glowka commented 5 years ago

oh, I have just realized no review was requested here only after I rebased it :upside_down_face:

kaglowka commented 5 years ago

It's ok :) I didn't do it since I wanted to discuss first what kind of feature this is. ;)

glowka commented 5 years ago

Were the toggle buttons supposed to look like that after the changes?

screenshot from 2019-01-10 18-47-48

kaglowka commented 5 years ago

No, definitely toggle buttons shouldn't look like that, I'll check it ;)

kaglowka commented 5 years ago

I'm merging this despite the bug so I can also rebase #276