search

PrzypisPowszechny / pp-client

7 stars 2 forks source link

Handle unlocated range annotaitons as not located #284

Closed kaglowka closed 5 years ago

kaglowka commented 5 years ago

Annotations located by quote are handled in case of location failure, but range annotations are still not.

E.g. at the moment of writing, the problem can be seen here: https://www.polskieradio.pl/7/129/Artykul/2179265

Consequently they won't be displayed in any summaries / counts (in popup and badge)

kaglowka commented 5 years ago

I gave it a try, but it cannot be easily improved at all now as of 0.5.0-alpha -- I've added it to my list of things to take into account in the next major application refactor: https://app.nuclino.com/Przypis-Powszechny-pp/Roboczy/KG-do-uwzgldnienia-przy-refactorze-13f2f62f-b1ad-445c-b89c-594d4f04f719

glowka commented 5 years ago

Annotations located by quote are handled in case of location failure, but range annotations are still not.

What does handle mean in this context? In other words, what is current behavior for finding location failure?

I've added it to my list of things to take into account in the next major application refactor

Looks like a typical issue, how about storing it on github?

kaglowka commented 5 years ago

Annotations located by quote are handled in case of location failure, but range annotations are still not.

What does handle mean in this context? In other words, what is current behavior for finding location failure?

When an annotation is not located by quote, it is not displayed anywhere in the interface, a warning is displayed in the console and an event is sent to sentry. In case of failure locating an annotation by range, it is displayed in popup as if it's been correctly highlighted (even though it's not).

I've added it to my list of things to take into account in the next major application refactor

Looks like a typical issue, how about storing it on github?

Like a "refactor" issue, enumerating other issues that should be taken into account while restructuring the application? That sounds nice.

kaglowka commented 5 years ago

I created the pending issue list in #291

glowka commented 5 years ago

You can even use "Pin issue" option (bottom of right panel on issue page) if it is kind of refactor list singleton :D

kaglowka commented 5 years ago

Currently all annotations are located using quote rather than range (range is used only as an intermediary between quote and the resulting HTML highlighting).

This issue is now outdated.