search

PrzypisPowszechny / pp-client

7 stars 2 forks source link

Improve error handling in communication with background + misc #312

Closed kaglowka closed 5 years ago

kaglowka commented 5 years ago

Resolve #289 For now we use only chrome.storage.local. We might switch later to sync if we need any kind of data to be shared between browser instances.

glowka commented 5 years ago

I guess these changes were rather preliminary and were followed by much thorough works, so the #313 is actually the proper one which will be merged soon, while this one can just be closed, right @kaglowka ?

kaglowka commented 5 years ago

No, they are completely independent :) probably with minor conflicts

glowka commented 5 years ago

But isn't this one containing some incomplete changes, e.g. mocking that was fixed later on?

On Mon, 4 Mar 2019 02:54 kaglowka, notifications@github.com wrote:

No, they are completely independent :) probably with minor conflicts

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/PrzypisPowszechny/pp-client/pull/312#issuecomment-469092092, or mute the thread https://github.com/notifications/unsubscribe-auth/AFSs-E90kq9FrGBkyfIWn8vnQkpgPhqxks5vTHzLgaJpZM4bQri5 .

kaglowka commented 5 years ago

No, I removed the dev client mock + there is no differentiation between the type of storage used in dev and production (all use chrome.storage.local and never chrome.storage.sync).

The next PR adds chrome API mock in jest tests.