search

PrzypisPowszechny / pp-client

7 stars 2 forks source link

Set up background driven authorization #340

Closed glowka closed 5 years ago

glowka commented 5 years ago

Resolves #325

glowka commented 5 years ago

Some e2e tests seems a bit unstable, they sometimes pass, sometimes not. There must be some kind of issue with them. I need to check it before merging.

kaglowka commented 5 years ago

The upgrade to React >= 16.4 stops Viewer from appearing (#314) I'll add a simple (and important) e2e test to detect problems like that.

kaglowka commented 5 years ago

Since changing the logic of Viewer appearing is rather time-consuming and I'm sure we'd like to rework it sooner or later anyway, I guess it's better to stick to React 16.3 (and possibly other packages like e.g. jest) for now.

kaglowka commented 5 years ago

I've added a viewer test to #339 (the test is passed at that point). It won't be passed in this PR

glowka commented 5 years ago

I'll revert that react upgrade.

Thanks a lot for the regression test!

glowka commented 5 years ago

Some e2e tests seems a bit unstable, they sometimes pass, sometimes not. There must be some kind of issue with them. I need to check it before merging.

BTW Upgrading jest and stuff stabilized the tests :)

glowka commented 5 years ago

I rebased it on master with this new test – passing after your @kaglowka downgrade

glowka commented 5 years ago

@kaglowka Happy to read your immensely positive review :)