Refactor e2e tests

[kaglowka]

• [ ] unify url building so it is DRY
• [ ] try to avoid restarting browser after most of the tests (and reset the browser state by clearing existing tabs etc.)
• other?

[glowka]

try to avoid restarting browser after most of the tests (and reset the browser state by clearing existing tabs etc.)

This is jest characteristic of jest that one spec file = one process. By default jest run in multiple processes (in hour case this is limited by server port) and one spec file is a thread unit here, so the browser being killed when a spec is finished is really deep-rooted. The common solution is to run related tests in one spec file and do not split the cases between files to easily.

[kaglowka]

try to avoid restarting browser after most of the tests (and reset the browser state by clearing existing tabs etc.)

This is jest characteristic of jest that one spec file = one process. By default jest run in multiple processes (in hour case this is limited by server port) and one spec file is a thread unit here, so the browser being killed when a spec is finished is really deep-rooted. The common solution is to run related tests in one spec file and do not split the cases between files to easily.

No, sorry, I didn't think there was another meaning to this point. I meant something else.

Currently in multi-tab e2e tests (i.e. including popup) I've made browser restart in beforeEach rather than beforeAll. This slows these test case considerably, of course.

[glowka]

Oh, Ok