Pshy0 / es-ruin-the-fun

A development / cheat plugin for Endless Sky. Access all ships and outfits, change your captain's name, choose the color swizzle of your ships, edit your relation with other governments, set your combat rank, hire a powerful escort, gift yourself pre-outfitted ships, give yourself money, and much more.
Mozilla Public License 2.0
4 stars 1 forks source link

Fixing outfits and adding new ones. #23

Closed mys721tx closed 10 months ago

mys721tx commented 11 months ago

Adds power and scan to God Mode outfit.

Pshy0 commented 11 months ago

Thank you for your contribution!

When I made the God Mode outfit, I intended it to contain all attributes that would guarantee the ship survives fights and environmental hazards (such as the waste's storms or other mod effects that would kill you very quickly), while also resisting effects that could disable it. This outfit is supposed to make you immortal.

For protecting against energy lost, I would use * resistance and * protection attributes, so that it does not affect the ship stats (so you can make a ship immortal while trying to balance it's energy or scanning stats, or others). I believe I added the cooling attribute in addition to burn protection because I used to believe only this would work against hazards (I still did not check if this is the case). I also added bunks to survive boarding, I should probably not have done that as this is the player's choice to board anyway.

But I agree an all-in-one outfit would be convenient. Either this could be turned into it, and a separate Immortality outfit be created, or the other way around, keeping the function of this one and adding another.

What do you think?

mys721tx commented 11 months ago

One problem I had with the attribute outfits is that when you have silly amount of them (>5000), the game slows down. I think splitting them would be a good idea like the cargo space * 100000 outfits.

How about separate them in the the following?

  1. Hull
  2. Shield
  3. Energy
  4. Heat
  5. Scan
  6. Fuel
Pshy0 commented 11 months ago

So is the idea to provide, to the individual stat outfits that you would need to stack in high amounts, an alternative outfit that is a higher value?

mys721tx commented 11 months ago

Here is my attempt at splitting the outfits. Let me know what you think!

Pshy0 commented 11 months ago

I just added 2 outfit categories RTF God Outfits and Individual Stats to sort RTF outfits better than putting them in Unique and Special.

Pshy0 commented 11 months ago

I am testing this PR.

Pshy0 commented 11 months ago

When ready, I will do a squash merge, so there will eventually only be one commit added to the repository. You do not need force pushing. And that would also let me contribute to the PR if you permitted it. And that would also help me see what changed between something I already checked/tested and the latest commit.