PsiQ / bartiq

Bartiq
https://psiq.github.io/bartiq/
Apache License 2.0
29 stars 9 forks source link

Compilation should not expose children resources by default #63

Closed mstechly closed 3 months ago

mstechly commented 3 months ago

Right now when we run compile_routine, children resources get propagated to the parent, so we might get resources with keys such as child_1.t, child_2.t. This is somewhat confusing and might require extra logic in integrations/postprocessing. It's also unnecessary, since this information is already in the Routine object anyway, so if someone wants to get it, they can easily do this.

I think we should simply remove it. Perhaps, we could leave a flag that propagates children costs to the parent, but to be honest, I have no idea what was the reasoning for it and it looks like a legacy logic for me that no longer needs to be there.

CC: @dexter2206