PssbleTrngle / DataTrades

Allows easy customization of villager trades using datapacks
Creative Commons Zero v1.0 Universal
1 stars 0 forks source link

Wandering Traders only take one rare trade regardless of value in wandering.json file #7

Closed CraftyG closed 1 year ago

CraftyG commented 1 year ago

What happened?

Expectation

From the wandering trader example data pack, 2 trades should be chosen from the rare pool.

  "rare": {
    "take": {
      "type": "constant",
      "value": 2
    },
    "trades": [
      {
        "sells": {
          "item": "chainmail_boots"
        },
        "wants": [
          {
            "item": "lapis_lazuli",
            "count": 14
          }
        ]
      }, {
        "sells": {
          "item": "chainmail_chestplate"
        },
        "wants": [
          {
            "item": "lapis_lazuli",
            "count": 14
          }
        ]
      }, {

Observation

Only one trade has been chosen. Changing the values to higher numbers has no effect.

2023-09-25_13 14 06

Loader

forge

Mod Version

1.1.0

Minecraft Version

1.19

Relevant log output

No response

PssbleTrngle commented 1 year ago

Yes, right now the wandering trader always only takes one trade, because I did not yet find a good solution to overwrite that, but I look into it

PssbleTrngle commented 1 year ago

Release an update that should fix this