PssbleTrngle / SliceAndDice

Making automation for Farmer's Delight more sensible
https://www.curseforge.com/minecraft/mc-mods/slice-and-dice
Other
19 stars 14 forks source link

[Compat] Compatibility with Farmer's Delight Refabricated [Fabric 1.20.1] #140

Closed pokesmells closed 5 months ago

pokesmells commented 6 months ago

Describe the feature you have in mind.

The new port of Farmer's Delight is not supported yet, and doesn't work with Slice & Dice. https://www.curseforge.com/minecraft/mc-mods/farmers-delight-refabricated

Does this solve a particular problem?

It offers more support for a better port which is more faithful to the original mod on Forge, and so Slice & Dice can be used alongside with the new port without crashing when generating a new world.

squimbo commented 6 months ago

Would kill for this 👍

Allexio commented 6 months ago

Describe the feature you have in mind.

The new port of Farmer's Delight is not supported yet, and doesn't work with Slice & Dice. https://www.curseforge.com/minecraft/mc-mods/farmers-delight-refabricated

Does this solve a particular problem?

It offers more support for a better port which is more faithful to the original mod on Forge, and so Slice & Dice can be used alongside with the new port without crashing when generating a new world.

A "better port" is very subjective, especially when you consider how it was made:

As much as I am a firm believer in open source and the healthy community that is the modding scene, this goes against so much that I believe in that I can not in good conscience use this mod or any other mod from MehVahdJukaar.

pokesmells commented 6 months ago

And for the record, let's face it, the only reason you want it updated is because you want to use the latest Supplementaries that forces you to use MehVahdJukaar's version. Not because the original port was inadequate.

No, it's not merely for that reason only, if you would've actually taken a look at Farmer's Delight Refabricated, it has significantly less trash in it's code, and it has removed many many bits of ambiguous code.

I want it because it's cleaner internally and more close to the actual original mod on Forge.

Second, you need not contact the original devs due to the absolute uncertainty and lack of responses to PR's.

I merely want support for a port that is faithful to the original codebase, and is cleaner internally.

bravely-beep commented 6 months ago

And for the record, let's face it, the only reason you want it updated is because you want to use the latest supplementaries that forces you to use MehVahdJukaar's version. Not because the original port was inadequate.

This is a pretty disrespectful response that makes a bunch of assumptions about other people. If you're against supporting the new FD port for moral reasons, sure, but don't bring personal attacks into it.

Personally I use the new FD port as it's more up-to-date with the Forge upstream version, and I'd be quite pleased if this mod has support for it added.

pokesmells commented 6 months ago

And for the record, let's face it, the only reason you want it updated is because you want to use the latest supplementaries that forces you to use MehVahdJukaar's version. Not because the original port was inadequate.

This is a pretty disrespectful response that makes a bunch of assumptions about other people. If you're against supporting the new FD port for moral reasons, sure, but don't bring personal attacks into it.

Personally I use the new FD port as it's more up-to-date with the Forge upstream version, and I'd be quite pleased if this mod has support for it added.

Agreed, but we had talked it out on discord, but again, I did mention to them that it was distasteful for that last comment.

All in all, let me support and use what I want.

TheLegendofSaram commented 6 months ago

this is reddit now

PssbleTrngle commented 6 months ago

This will very likely happen, although as soon as it does, the other implementation will no longer be supported

pokesmells commented 6 months ago

This will very likely happen, although as soon as it does, the other implementation will no longer be supported

The other version was recently listed as "Deprecated" image

So many others may soon drop support for it as well.

Allexio commented 6 months ago

More than the mod now being deprecated, the mod author behind the original port basically quit modding because of what happened, which is understandable.

dhouck commented 5 months ago

More than the mod now being deprecated, the mod author behind the original port basically quit modding because of what happened, which is understandable.

Can you provide a link to this? I canʼt find any acknowledgement at all besides changing the CF page to say deprecated, and it looks like they hadnʼt been doing any development for months.

Allexio commented 5 months ago

There is no link, it all happened on his discord, which he now shut down. Multiple people were present when it went down.

On Sat, 13 Apr 2024, 5:15 pm Daniel Houck, @.***> wrote:

More than the mod now being deprecated, the mod author behind the original port basically quit modding because of what happened, which is understandable.

Can you provide a link to this? I canʼt find any acknowledgement at all besides changing the CF page to say deprecated, and it looks like they hadnʼt been doing any development for months.

— Reply to this email directly, view it on GitHub https://github.com/PssbleTrngle/SliceAndDice/issues/140#issuecomment-2053674332, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOHNZ6FFQBJPEFKWRIGLOTTY5FD2HAVCNFSM6AAAAABFNJL7J2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJTGY3TIMZTGI . You are receiving this because you commented.Message ID: @.***>

ninjaeon commented 5 months ago

And for the record, let's face it, the only reason you want it updated is because you want to use the latest supplementaries that forces you to use MehVahdJukaar's version. Not because the original port was inadequate.

I'm in this boat. So for now, it's stay with the original port farmers-delight-fabric-1.4.3.jar and supplementaries-1.20-2.8.7-fabric.jar so I can keep using Slice & Dice. Thank you for this great mod!

PssbleTrngle commented 5 months ago

finally done, let me know if everything still works