search

PssbleTrngle / SliceAndDice

Making automation for Farmer's Delight more sensible
https://www.curseforge.com/minecraft/mc-mods/slice-and-dice
Other
17 stars 15 forks source link

Invalid Class Reference/Mixin Target #75

Closed rinebergc closed 1 year ago

rinebergc commented 1 year ago

What happened?

Mod will throw a warning is KubeJS is missing. The warning goes away if KubeJS is installed. Mod should not make class reference to/target another mod, unless such mod is a dependency.

Loader

fabric

Mod Version

2.1.3

Minecraft Version

1.19

Relevant log output

[main/WARN]: Error loading class: dev/latvian/mods/kubejs/recipe/RecipesEventJS (java.lang.ClassNotFoundException: dev/latvian/mods/kubejs/recipe/RecipesEventJS)

[main/WARN]: @Mixin target dev.latvian.mods.kubejs.recipe.RecipesEventJS was not found sliceanddice.mixins.json:RecipeEventJSMixin from mod sliceanddice
PssbleTrngle commented 1 year ago

Yes, this is intentional, since it's an optional mixin into a KubeJS class, which will print a warning if it fails

Xyphenore commented 9 months ago

I don't know how mixins work in mods. But isn't it possible to display an information instead of a warning, to indicate that KubeJS is missing and the mod doesn't load the extra recipes?

PssbleTrngle commented 9 months ago

The mod still works if KubeJS is missing, the mixin is only there to make it work if kubejs is present too. And there would probably a way to somehow hide it but that would be way to much effort just to hide one warning in the log, especially since modpacks usually print a ton of warnings anyway