Psy-Fer / SquiggleKit

SquiggleKit: A toolkit for manipulating nanopore signal data
MIT License
122 stars 23 forks source link

Unable to use SquigglePull to read event data #12

Closed VidurangaWijekoon closed 5 years ago

VidurangaWijekoon commented 5 years ago

Hello,

I just started using SquiggleKit, and am trying to use SquigglePull to read raw and event data in the fast5 files provided in the repository. Raw data are read as expected, but I cannot get it to read event data. I am getting the following error.

image

I checked the code at the specified line, and it looks to me as if the error message is valid. But this is the first time I am using Python, so I am most probably wrong. My version of Python is 2.7.15rc1, and I am using the library on Ubuntu in Windows 10.

Could someone please help me in getting the issue fixed? Thanks in advance!

Psy-Fer commented 5 years ago

Hello,

Ahh, yes I have not given the even extraction much care, as I was planning to remove it.

The problem was when I added the read_id extraction, I didn't port refrence c = hdf['Raw/Reads'].keys() to be able to find it in the event extraction logic.

I just did a quick little update.

Please do a git pull and try again.

Cheers, and thanks for using SquiggleKit

Psy-Fer commented 5 years ago

Hey there,

any news if that fix worked?

VidurangaWijekoon commented 5 years ago

Hi,

Thanks a lot for the fix. Just checked it out. It does give an output, but I am not sure whether the values are correct. I tested with the test.fast5 file provided with the repository, and for event extraction, did not use any optional commands. For raw data, I get values around 500, and for event data, they are around 100. I am not sure whether it is supposed to be like that.

I am attaching both the outputs for your reference.

outputs.zip

Psy-Fer commented 5 years ago

Yes, that's correct.

The events are in a different range to the raw asic measurements.

So that is expected output.

On Thu., 23 May 2019, 8:17 am VidurangaWijekoon, notifications@github.com wrote:

Hi,

Thanks a lot for the fix. Just checked it out. It does give an output, but I am not sure whether the values are correct. I tested with the test.fast5 file provided with the repository, and for event extraction, did not use any optional commands. For raw data, I get values around 500, and for event data, they are around 100. I am not sure whether it is supposed to be like that.

I am attaching both the outputs for your reference.

outputs.zip https://github.com/Psy-Fer/SquiggleKit/files/3210729/outputs.zip

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Psy-Fer/SquiggleKit/issues/12?email_source=notifications&email_token=ACERX2LDSYUDDUBZSNP2AGTPWZAJXA5CNFSM4HNAJ5D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWBJP4Q#issuecomment-495097842, or mute the thread https://github.com/notifications/unsubscribe-auth/ACERX2KEMEX5HOSFY7WF3ELPWZAJXANCNFSM4HNAJ5DQ .