Psy-Fer / buttery-eel

The buttery eel - a slow5 guppy/dorado basecaller wrapper
MIT License
34 stars 2 forks source link

Add version checks for guppy and lib #13

Closed Psy-Fer closed 1 month ago

Psy-Fer commented 1 year ago

After starting the guppy server but before connecting a client, I should do a check that the guppy server version matches the installed guppy client lib version.

I think I can do this with some API calls to the server and some lib version check stuff for the lib.

This should help give a more informative error in the case where they don't match but the output is...weird and not helpful.

Psy-Fer commented 1 year ago

Ahh i already do such a lib check using

major, minor, patch = [int(i) for i in pyguppy_client_lib.__version__.split(".")]
Psy-Fer commented 2 months ago

Add this into the lib checks, with the exception that 7.3.9 and 7.3.10 are the same, and not wrong.