Can the abort button be hiddenor show something in green like success after all steps complete?

Psy-Fer / interARTIC

InterARTIC - An interactive local web application for viral whole genome sequencing utilising the artic network pipelines..

https://psy-fer.github.io/interARTIC/

MIT License

29 stars 7 forks source link

Can the abort button be hiddenor show something in green like success after all steps complete? #59

Closed hasindu2008 closed 3 years ago

hasindu2008 commented 3 years ago

When a job completes, the abort button becomes bigger than before and this may mislead someone to think that the job failed.

before:

after:

Psy-Fer commented 3 years ago

Something weird about the button becoming bigger, but as a way around this, I've changed it to be "success" when no errors are detected.

Psy-Fer commented 3 years ago

okay, i had the logic around the wrong way. This should work now. I tested with a fresh run (no errors) and a dodgy run (with errors) and it looks the way it should.

https://github.com/Psy-Fer/interARTIC/commit/d66b8b235846a03259cfc0d55d14f30f5fb7c20d

hasindu2008 commented 3 years ago

works