search

Psychedelic / DAB-js

JS library that wraps necessary methods to integrate DAB and its NFTs.
GNU General Public License v3.0
28 stars 19 forks source link

extImageUrl is arbitrary and hard-coded. #63

Open wyattbenno777 opened 2 years ago

wyattbenno777 commented 2 years ago

extImageUrl is arbitrary and hard-coded: DAB should accept a method for EXT tokens to reveal their URIs.

showURL(tokenIdentifier) Text {
  // returns the URL as a text. 
  // EXT does not define what is in the metadata, so it can be anything.
  // The easiest way to get the asset URI is not to hardcode, but to ask the canisters for it.
}

Just like there is a method for canisters to show their logo_url.

https://github.com/Psychedelic/DAB-js/blob/d4e57582eb71a56fdcfc871dd4ee3a26d9a6c21d/src/standard_wrappers/nft_standards/ext.ts#L23

wyattbenno777 commented 2 years ago

Still seems hardcoded

https://github.com/Psychedelic/DAB-js/blob/d4e57582eb71a56fdcfc871dd4ee3a26d9a6c21d/src/standard_wrappers/nft_standards/ext.ts#L23

How active is the dev team here? Would a pull request be better??