search

Psychedelic / DIP721

DIP721 - An Internet Computer Non-fungible Token Standard
GNU General Public License v3.0
62 stars 28 forks source link

mintDip721 from spec.md is different than mintDip721 from nft/src/service.rs #21

Open sakunix opened 2 years ago

sakunix commented 2 years ago

imagen

imagen

heldrida commented 2 years ago

Hi @sakunix , thanks for reporting. The Nft implementation example ( https://github.com/Psychedelic/DIP721#-nft-implementation-example ) is indeed missing some of the features in the specs; I find that overall, requires a revamp, so I've started looking at it and you'll notice several changes happening in the next few days. Follow development in the develop branch ( https://github.com/Psychedelic/DIP721 ). PRs ( https://github.com/Psychedelic/DIP721/pulls ).

sakunix commented 2 years ago

Hi @sakunix , thanks for reporting. The Nft implementation example ( https://github.com/Psychedelic/DIP721#-nft-implementation-example ) is indeed missing some of the features in the specs; I find that overall, requires a revamp, so I've started looking at it and you'll notice several changes happening in the next few days. Follow development in the develop branch ( https://github.com/Psychedelic/DIP721 ). PRs ( https://github.com/Psychedelic/DIP721/pulls ).

very well thank you