docs: (spec) private property prefix, remove data blob

ozwaldorf commented 2 years ago

Why?

Based on some feedback from the community (cc @jorgenbuilder ), there is a need for specifying if a given key value should be displayed in frontends (eg; plug wallet's trait chips).

This also removes the requirement of the data blob, as storing large amounts of data in the meta is not recommended, due to the IC's 2MB message limit.

How?

Adds the _ prefix for private properties to the spec

Removed reserved property data

Tickets?

n.a

Contribution checklist?

[ ] The commit messages are detailed
[ ] It does not break existing features (unless required)
[ ] I have performed a self-review of my own code
[ ] Documentation has been updated to reflect the changes
[ ] Tests have been added or updated to reflect the changes
[ ] All code formatting pass
[ ] All lints pass
[ ] All tests pass

Security checklist?

n.a

Demo?

n.a

ozwaldorf commented 2 years ago

This addresses the use case I have in mind for "developer properties" perfectly. @ozwaldorf I'd like to get some comments from others on my other suggestions as well: multiple asset locations in metadata beyond location and thumbnail. Should I create a separate PR for that?

A PR would be much appreciated! Along with this though, do you think we should move all the reserved properties to the private _ namespace? So location would be _location, _location1, etc; thumbnail would be _thumbnail, _thumbnail2, etc

jorgenbuilder commented 2 years ago

do you think we should move all the reserved properties to the private _ namespace? So location would be _location, _location1, etc; thumbnail would be _thumbnail, _thumbnail2, etc

Fair point. Let's discuss in the new PR.

Psychedelic / DIP721