Psychedelic / dank

Dank - The Internet Computer Decentralized Bank - A collection of Open Internet Services - Including the Cycles Token (XTC)
GNU General Public License v3.0
58 stars 27 forks source link

NFT-Draft #32

Closed ferencdg closed 3 years ago

ferencdg commented 3 years ago

no proper support for NFT metadata until the standard changes no support for account identifier no support for history no support for allowances no fees no tests extensions method missing contains some inefficient copying/missing inline attributes... warnings suppressed

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 1257697921


Changes Missing Coverage Covered Lines Changed/Added Lines %
nft/src/utils.rs 0 13 0.0%
nft/src/service.rs 0 46 0.0%
nft/src/types.rs 0 56 0.0%
nft/src/nft_ledger.rs 0 59 0.0%
<!-- Total: 2 176 1.14% -->
Files with Coverage Reduction New Missed Lines %
xtc-history/xtc-history/src/flush.rs 3 77.97%
../../../github/home/.cargo/registry/src/github.com-1ecc6299db9ec823/num-bigint-0.4.2/src/biguint.rs 5 59.09%
../../../github/home/.cargo/registry/src/github.com-1ecc6299db9ec823/candid-0.7.7/src/types/number.rs 6 33.33%
../../../github/home/.cargo/registry/src/github.com-1ecc6299db9ec823/serde-1.0.130/src/de/impls.rs 10 22.89%
../../../github/home/.cargo/registry/src/github.com-1ecc6299db9ec823/serde-1.0.130/src/de/mod.rs 12 25.53%
../../../github/home/.cargo/registry/src/github.com-1ecc6299db9ec823/candid-0.7.7/src/types/impls.rs 16 36.47%
../../../github/home/.cargo/registry/src/github.com-1ecc6299db9ec823/candid-0.7.7/src/de.rs 26 19.93%
<!-- Total: 78 -->
Totals Coverage Status
Change from base Build 1237303500: -5.4%
Covered Lines: 1635
Relevant Lines: 2937

💛 - Coveralls
kanej commented 3 years ago

@ferencdg there is nothing stopping us deleting this branch now?

ferencdg commented 3 years ago

let me delete it