Closed ambeeeeee closed 2 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
piggy-bank/src/lib.rs | 6 | 7 | 85.71% | ||
xtc-history/xtc-history-bucket/src/lib.rs | 0 | 2 | 0.0% | ||
xtc-history/xtc-history/src/data.rs | 1 | 3 | 33.33% | ||
xtc/src/history.rs | 1 | 3 | 33.33% | ||
xtc/src/cycles_wallet.rs | 33 | 36 | 91.67% | ||
xtc-history/xtc-history/src/ic.rs | 0 | 4 | 0.0% | ||
xtc/src/stats.rs | 4 | 8 | 50.0% | ||
xtc/src/ledger.rs | 28 | 33 | 84.85% | ||
xtc/src/upgrade.rs | 0 | 7 | 0.0% | ||
xtc/src/management.rs | 2 | 10 | 20.0% | ||
<!-- | Total: | 81 | 119 | 68.07% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
../../../github/home/.cargo/registry/src/github.com-1ecc6299db9ec823/ic-kit-0.4.2/src/mock.rs | 1 | 81.21% | ||
xtc/src/upgrade.rs | 1 | 0% | ||
xtc-history/xtc-history-bucket/src/lib.rs | 3 | 2.27% | ||
xtc/src/management.rs | 3 | 20.0% | ||
<!-- | Total: | 8 | --> |
Totals | |
---|---|
Change from base Build 1265846663: | 0.4% |
Covered Lines: | 1645 |
Relevant Lines: | 2682 |
thanks for the code cleanup
This PR looks okay to me, but can we wait with merging it into the main? The ERC-20 compatibility PR will have a lot of conflicts with this one, and we have a release date for that PR.
This PR looks okay to me, but can we wait with merging it into the main? The ERC-20 compatibility PR will have a lot of conflicts with this one, and we have a release date for that PR.
Agreed. Let's get this merged in after the ERC-20 updates.
I can clean up any conflicts after the ERC-20 merge.
I can clean up any conflicts after the ERC-20 merge.
thank you, we merged erc20 yesterday
I can clean up any conflicts after the ERC-20 merge.
thank you, we merged erc20 yesterday
Awesome, I'll get to work on this ASAP
@ambeeeeee Let me know please if the rebase if done, so I can merge and we can release it with the fee fixes.
If you are busy, I can just do the rebase too.
very outdated by now
Adds clippy to the CI workflow for
dank
. Resolves all clippy lints as well.Notable changes:
#![allow(dead_code)]
toxtc
to get the lints to pass for the PR, I don't know enough about the project to know if the structs should be re-exported or the modules made public to resolve the dead code lints.