search

Psychedelic / plug-mobile

Plug - Mobile App version of Plug, the crypto wallet of the Internet Computer!
GNU General Public License v3.0
26 stars 5 forks source link

Import Accounts mobile #494

Open mattgle opened 1 year ago

mattgle commented 1 year ago

Description

We want to give the option to the users of importing sub-accounts using pem files, this is a change that the new controller will bring and we need to support it in the mobile apps too

alinasytnik commented 1 year ago

✳️Improvement

Description

Show the error message if the account has already been imported.

Steps to Reproduce

  1. Open the Plug app
  2. Create a wallet
  3. Go to the Activity tab
  4. Click the Change button
  5. Click the Create/Import account button
  6. Click on the Private Key (or the PEM file) button
  7. Insert PK (or PEM) Current: Notice that the Create Account modal is shown, and the user can add the already imported/created account.

Expected behavior

The "This account is already imported" message should be shown.

Screenshots

https://user-images.githubusercontent.com/33018206/197538324-08a713ff-e82a-49a7-be61-03b0bae41958.mov

https://user-images.githubusercontent.com/33018206/197538385-8b2e0043-e494-4a18-b265-d2700ea3949f.MP4

Smartphone (please complete the following information):

alinasytnik commented 1 year ago

⚠️Bug

Description

ICP transaction fails

Steps to Reproduce

  1. Open the Plug app
  2. Create a wallet
  3. Go to the Tokens tab
  4. Click on ICP and choose the Send option
  5. Try to send ICP Current: Notice that the transaction failed.

Expected behavior

ICP transactions should be processed successfully

Screenshots

https://user-images.githubusercontent.com/33018206/197549805-833bae9e-8298-401e-a29c-83a6443cccc9.MP4

Smartphone (please complete the following information):

alinasytnik commented 1 year ago

⚠️Bug

Description

Validation for Private Key input.

Steps to Reproduce

  1. Open the Plug app
  2. Create a wallet
  3. Go to the Activity tab
  4. Click the Change button
  5. Click the Create/Import account button
  6. Click on the Private Key button
  7. Insert Principal or Account ID instead of Private Key Current: Notice that the new subaccount was created.

Expected behavior

The user shouldn't be able to create a new subaccount this way. I think that we can add validation for the Private Key input.

Screenshots

https://user-images.githubusercontent.com/33018206/197551333-05197371-57a9-4935-8e55-5526e2936cec.MP4

Smartphone (please complete the following information):

kevin4476 commented 1 year ago

⚠️ BUG: App doesn't allow download PEMs files

Testing Information

Precondition

Issue: The app doesn’t allow to download the PEM file

https://user-images.githubusercontent.com/108067829/197896344-eb66924c-9434-4df3-b19d-89587ff2e791.mp4

https://user-images.githubusercontent.com/108067829/197896412-9e215466-8ae1-4020-a1e4-cd468a29a2e1.mp4

Additional Note

The application also does not allow you to import PEMs files

alinasytnik commented 1 year ago

✳️Improvement

Description

Show the more detailed error message "This account is already imported" instead of "Error while importing..." when account already imported or created.

Steps to Reproduce

  1. Open the Plug app
  2. Create a wallet
  3. Go to the Activity tab
  4. Click the Change button
  5. Click the Create/Import account button
  6. Click on the Private Key (or the PEM file) button
  7. Try to add the already existing account. Current: Notice that the error message does not show the essence of the error.

Expected behavior

The "This account is already imported" message should be shown.

Screenshots

Image

Smartphone (please complete the following information):

alinasytnik commented 1 year ago

⚠️Bug

Description

An error occurred during subaccount creation.

Precondition

  1. Create a NEW account
  2. Add the subaccount with a Private Key
  3. Add the subaccount with PEM File

Steps to Reproduce

  1. Open the Plug app
  2. Create a wallet
  3. Go to the Activity tab
  4. Click the Change button
  5. Click the Create/Import account button
  6. Click on the Create Account button Current: Notice that the new subaccount wasn't created, and an error occurred.

Expected behavior

The user should be able to create a new subaccount.

Screenshots

https://user-images.githubusercontent.com/33018206/202048552-75c1a4ac-c1af-4f7a-9edd-14e6f1ffeabe.MP4

Smartphone (please complete the following information):

kevin4476 commented 1 year ago

⚠️ App gets slow

Testing Information

Precondition

Issue: When I import an Account using the PEM file the app it gets slow and the NFTs not load

https://user-images.githubusercontent.com/108067829/202067333-4803f00b-38fb-417a-a126-86646314362b.mp4

Additional Information