search

PsychoTea / Oxide.Ext.Discord

Discord extension and integration
https://umod.org/extensions/discord
12 stars 25 forks source link

Request fixes. #11

Closed Slut closed 6 years ago

Slut commented 6 years ago

If a request was made under ratelimit it would get removed from bucket rather than staying in the queue, it should now only remove requests that shouldn't be sent again such as 404's.

I've also moved the LogWarning to only log warnings if the exception isn't a ratelimit.

PsychoTea commented 6 years ago

I suspect there's a better way of doing this than turning the StatusCode to a string and parsing back to an int. I'll take a look here and see if I can find a slightly better way.

By the way, it would be great in future if you could create separate PR's for different commits/edits; aka splitting your Request and Message commits. This means I can accept/close them separately without having to manually add in other changes.

PsychoTea commented 6 years ago

I've merged the changes manually so we should be all good now.