search

Psychoanalytic-Electronic-Publishing / PEP-Web-User-Interface

Single Page App Graphical User Interface for PEP-Web
1 stars 0 forks source link

Translation Links (non GW/SE) are not implemented in the client #703

Open nrshapiro opened 1 year ago

nrshapiro commented 1 year ago

@ocappello @davidtuckett @jordanallen-dev @SophieMBennett

The client doesn't appear to use the general translation data returned by the server (except for GW/SE links). These links are coded in the XML in the origrx field of artinfo.

We could piggyback this information in the Related Documents area of the client (where I thought it was implemented, but does not appear to be), or create a new infocard for it. The new infocard might be considered because most of the documents that are translated are in IJP, which also has a fair number of related documents via the artqual linking.

However, it may not be confusing to put them all in the same infocard. For discussion.

@jordanallen-dev (if you could check the client code to confirm that it is not looking in the translationset field of the documentlist items returned. It could also be that the translation flag of the call to /v2/Documents/Document isn't set so the translations aren't returned UPDATTE: 1) I just confirmed this...but I am going to change the default for the flag to True for the next version of the server...I don't see any issue with just leaving that on. 2) On my test PC, turning that flag on still didn't display the data in the client for document IJP.086.1523A, which has 1 translation recorded.

For Me: I need to also check on the ANIJP documents to make sure Aptara is consistently recording the origrx.

davidtuckett commented 1 year ago

Lets discuss when looked into. There are a number of other info card issues and enhancements to discuss but I am mindful we need to stick to priorities. For the moment good to record issues and possible solutions?

nrshapiro commented 1 year ago

@davidtuckett @ocappello - You can use the labels on the right to set priorities. They were added for Orazio but either of you can set. The one marked DT was so I could mark it for you when you said it was very high.

image
nrshapiro commented 1 year ago

Although a list of translated documents comes back with each document you viewed (for use in an infocard), you could also add an icon to the top of the document or by the title which could bring up a list of translations from a search, similar to the rxcf feature. That would work like the old system.

If you choose that, you should turn off the return of the list of translations which is selected via the options flag in the retrieve document call to the server.