Closed jdkent closed 3 years ago
Merging #452 (6c4231b) into master (6fb1b23) will decrease coverage by
0.26%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #452 +/- ##
==========================================
- Coverage 75.73% 75.46% -0.27%
==========================================
Files 65 65
Lines 3820 3779 -41
==========================================
- Hits 2893 2852 -41
Misses 927 927
Impacted Files | Coverage Δ | |
---|---|---|
pliers/converters/api/wit.py | 45.65% <0.00%> (-2.27%) |
:arrow_down: |
pliers/support/decorators.py | 80.00% <0.00%> (-1.82%) |
:arrow_down: |
pliers/transformers/api/google.py | 40.00% <0.00%> (-1.18%) |
:arrow_down: |
pliers/transformers/api/microsoft.py | 25.00% <0.00%> (-1.16%) |
:arrow_down: |
pliers/stimuli/api.py | 37.73% <0.00%> (-1.16%) |
:arrow_down: |
pliers/converters/api/revai.py | 25.75% <0.00%> (-1.11%) |
:arrow_down: |
pliers/converters/api/ibm.py | 24.71% <0.00%> (-0.84%) |
:arrow_down: |
pliers/converters/base.py | 90.00% <0.00%> (-0.63%) |
:arrow_down: |
pliers/extractors/api/clarifai.py | 22.40% <0.00%> (-0.62%) |
:arrow_down: |
pliers/utils/base.py | 84.61% <0.00%> (-0.57%) |
:arrow_down: |
... and 11 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6fb1b23...6c4231b. Read the comment docs.
finally got it passing, for some reason I cannot run the pliers/tests/extractors/test_model_extractors.py
tests, (it times out), but should be ready for review otherwise @adelavega
Ah, that's a common issue with the timeout. This is why in the past I had to split the tests into multiple lines. It probably runs out of RAM.
Nice, looks good. Can you update the README or docs to reference how to use the Docker image, and document the overall behavior?
@adelavega there is a urllib error for the python tests that I'm not sure about, do you have any thoughts?
@adelavega, I think this is finally ready, there is a soft limit of 14GB of storage on the runner (but I never saw a warning I was running out of space), so I had to delete some very large unused files on the virtual machine so I could build the very large pliers image.
@adelavega, does this pull request look okay? once merged, it should fix the broken tests in #454
using github actions to build/distribute docker image
secrets.CR_PAT
needs to be created by someone with admin privileges. It's a personal access token, with package permissions, I can do it (if you think I should have admin access, hopefully to just this repository, but maybe need someone that is admin to the organization).