PsychoinformaticsLab / pliers

Automated feature extraction in Python
https://pliers.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
296 stars 68 forks source link

remove discoveryServiceUrl, update docs #478

Closed emdupre closed 2 years ago

emdupre commented 2 years ago

Closes #473.

Small documentation, build call updates for google-api-python-client usage. This is very much a first pass ; feedback welcome !

adelavega commented 2 years ago

Awesome! Do you know if you can get tests to pass locally for this extractor?

i.e.:

pytest pliers/tests/extractors/api/test_google_extractors.py

I think you might have to add GOOGLE_APPLICATION_CREDENTIALS to your environment

emdupre commented 2 years ago

Thanks ! I pushed a few updates on the tests that are necessary to match the new outputs.

Currently I'm still getting one failure:

(pliers) Desktop/pliers % GOOGLE_APPLICATION_CREDENTIALS='/Users/emdupre/Downloads/googleapi.json' pytest pliers/tests/extractors/api/test_google_extractors.py
==================================================================== test session starts ====================================================================
platform darwin -- Python 3.9.13, pytest-7.1.3, pluggy-1.0.0
rootdir: /Users/emdupre/Desktop/pliers, configfile: pytest.ini
collected 21 items                                                                                                                                          

pliers/tests/extractors/api/test_google_extractors.py .....F................                                                                           [100%]

Specifically, it's a 403 error on one of the test URLs:

FAILED pliers/tests/extractors/api/test_google_extractors.py::test_google_vision_api_label_extractor - urllib.error.HTTPError: HTTP Error 403: Forbidden

Do you have another URL that you'd recommend substituting here ?

adelavega commented 2 years ago

I think I fixed your issue in the general test fix. Hopefully tests pass and we can merge!

adelavega commented 2 years ago

Tests passing! @emdupre can you confirm this is ready to merge?

emdupre commented 2 years ago

This is ready on my side, thanks !!!