Closed emdupre closed 2 years ago
Awesome! Do you know if you can get tests to pass locally for this extractor?
i.e.:
pytest pliers/tests/extractors/api/test_google_extractors.py
I think you might have to add GOOGLE_APPLICATION_CREDENTIALS
to your environment
Thanks ! I pushed a few updates on the tests that are necessary to match the new outputs.
Currently I'm still getting one failure:
(pliers) Desktop/pliers % GOOGLE_APPLICATION_CREDENTIALS='/Users/emdupre/Downloads/googleapi.json' pytest pliers/tests/extractors/api/test_google_extractors.py
==================================================================== test session starts ====================================================================
platform darwin -- Python 3.9.13, pytest-7.1.3, pluggy-1.0.0
rootdir: /Users/emdupre/Desktop/pliers, configfile: pytest.ini
collected 21 items
pliers/tests/extractors/api/test_google_extractors.py .....F................ [100%]
Specifically, it's a 403 error on one of the test URLs:
FAILED pliers/tests/extractors/api/test_google_extractors.py::test_google_vision_api_label_extractor - urllib.error.HTTPError: HTTP Error 403: Forbidden
Do you have another URL that you'd recommend substituting here ?
I think I fixed your issue in the general test fix. Hopefully tests pass and we can merge!
Tests passing! @emdupre can you confirm this is ready to merge?
This is ready on my side, thanks !!!
Closes #473.
Small documentation,
build
call updates forgoogle-api-python-client
usage. This is very much a first pass ; feedback welcome !