search

Psycojoker / ipython-beautifulsoup

Pretty HTML/XML rendering with syntax highlighting for BeautifulSoup objects in IPython notebook and qtconsole.
68 stars 11 forks source link

configure_ipython_beautifulsoup, README, p requests, print() #3

Closed westurner closed 10 years ago

westurner commented 10 years ago

2

Psycojoker commented 10 years ago

Wow, great patch, thanks!

But it seems that you have triggered an encoding bug according to travis https://travis-ci.org/Psycojoker/ipython-beautifulsoup/builds/16377943#L833 ? Can you look at it and see if it's a real bug and if yes, fix it :)

Thanks in advance!

westurner commented 10 years ago

I added unittests and removed the explicit .encode('Utf-8)' of the output frompygments.highlight`.

It reads the file with codecs.open(encoding='utf-8').

As this doesn't write _repr_html_ to console, I may be missing a case / changing the goalposts here.

.. waiting for a (remote) build to start.

westurner commented 10 years ago

You might also update the github project description to reaqd "Pretty HTML/XML rendering with syntax highlighting for BeautifulSoup objects in IPython notebook and qtconsole." (syntaxe -> syntax)

Psycojoker commented 10 years ago

Merged, thanks a lot :)

I've also make some other modifications and updated the README.rst (I've removed the .md one) to match reality. If everything looks good for you, I'll release 0.2 on pypi.

westurner commented 10 years ago

Hey, thank you!

Looks great from here. I added the warning to configure_ipython_beautifulsoup about XSS unsafeness. It may or may not be helpful to add that or something similar to the README.

Something like https://github.com/jsocol/bleach would help reduce the risk of borking the loaded IPython notebook interface or, more nefarious mangling.

Anyways, thanks again!

Psycojoker commented 10 years ago

Added a warning, I'm waiting for travis to build, then I'll push a release on pypi.

It has been a pleasure collaborating with you :)

Psycojoker commented 10 years ago

Oh, and thanks for all the references on the issue #2!

westurner commented 10 years ago

Nice. Anytime!

Wes Turner

On Sun, Jan 5, 2014 at 6:33 PM, Laurent Peuch notifications@github.comwrote:

Added a warning, I'm waiting for travis to build, then I'll push a release on pypi.

It has been a pleasure collaborating with you :)

— Reply to this email directly or view it on GitHubhttps://github.com/Psycojoker/ipython-beautifulsoup/pull/3#issuecomment-31620706 .