make compatible with Python 2 and 3

MattDMo commented 10 years ago

Installed fine using Python 3.4 on Windows, and imports well using %reload_ext soup in IPython notebook.

MattDMo commented 10 years ago

OK, I've made a ton of changes, but hopefully you'll agree they're for the better. Here's an abbreviated list:

modified soup.py to work with both Python 2.7 as well as 3.3 and 3.4 (since they both support Unicode literals). Also removed BeautifulSoup3 code, as it's extremely outdated (2.5 years old), and people should really upgrade.
updated .travis.yml to test Python 3.3 and 3.4 and install libzmq3[-dev] ahead of time so pyzmq compilation works. Tests are currently passing.
updated test.py to work with Python 3
changed requirements.txt to require bs4
finally, redid setup.py to version 0.3 (you'll have to remember to draft a release when we're ready), fixed some grammar/spelling/capitalization minor quibbles in some text fields, modified install_requires and extras_require to reflect change to bs4, also added fairly large list of classifiers. You'll have to decide whether this is Alpha- or Beta-grade software - I picked Beta, but you can change it if you wish.

And that's about it. Definitely let me know what you think!

Psycojoker commented 10 years ago

I've just finished reviewing your changes and everything is great, thanks a lot :)

FYI, I've made a small refactoring to remove if statements related to python3 in the code https://github.com/Psycojoker/ipython-beautifulsoup/commit/0cbe89d8be3fe5d5f72c211db210819cdc2d4add I don't like if, they are source of bugs.

Psycojoker commented 10 years ago

Except if you want to do more things, I'm going to write a small CHANGELOG file then push this new version to pypi.

MattDMo commented 10 years ago

I was actually thinking about that later, but I got busy with some other stuff later in the day. Good idea!

On Aug 25, 2014, at 11:22 PM, Laurent Peuch notifications@github.com wrote:

I've just finished reviewing your changes and everything is great, thanks a lot :)

FYI, I've made a small refactoring to remove if statements related to python3 in the code 0cbe89d I don't like if, they are source of bugs.

— Reply to this email directly or view it on GitHub.

MattDMo commented 10 years ago

Sounds good to me.

On Aug 25, 2014, at 11:22 PM, Laurent Peuch notifications@github.com wrote:

Except if you want to do more things, I'm going to write a small CHANGELOG file then push this new version to pypi.

— Reply to this email directly or view it on GitHub.

Psycojoker commented 10 years ago

And released! https://pypi.python.org/pypi/ipython-beautifulsoup/0.3

I've also pushed a wheel version of the pkg.

Psycojoker / ipython-beautifulsoup

make compatible with Python 2 and 3 #5