search

Psycojoker / prosopopee

a static website generator to make beautiful customizable pictures galleries that tell a story
http://prosopopee.readthedocs.org
GNU General Public License v3.0
318 stars 55 forks source link

panorama broken since 729b946 #121

Closed gangelop closed 3 years ago

gangelop commented 3 years ago

panorama broken since 729b946

Currently in master at 0c6e83f build exits successfully but render fails in browser with console output:

jquery.min.js:2 Uncaught TypeError: e.indexOf is not a function
    at k.fn.init.k.fn.load (jquery.min.js:2)
    at HTMLElement.<anonymous> (jquery.panorama_viewer.min.js:1)
    at Function.each (jquery.min.js:2)
    at k.fn.init.each (jquery.min.js:2)
    at k.fn.init.e.fn.panorama_viewer (jquery.panorama_viewer.min.js:1)
    at (index):82
k.fn.load @ jquery.min.js:2
(anonymous) @ jquery.panorama_viewer.min.js:1
each @ jquery.min.js:2
each @ jquery.min.js:2
e.fn.panorama_viewer @ jquery.panorama_viewer.min.js:1
(anonymous) @ (index):82

Might investigate further but I've never touched jQuery before.

QSchulz commented 3 years ago

See: https://github.com/peachananr/panorama_viewer/issues/19#issuecomment-517641936 for how to fix this issue.

Considering this JS script hasn't seen any code update in the last 6 years and a half, maybe it'd be time to actually swap to something more recent?