Psycojoker / prosopopee

a static website generator to make beautiful customizable pictures galleries that tell a story
http://prosopopee.readthedocs.org
GNU General Public License v3.0
331 stars 56 forks source link

Add support of menu #9

Closed beudbeud closed 8 years ago

Psycojoker commented 8 years ago

Regarding menu.html I think that we should use template inheritance to avoid code duplication between index.html and menu.html http://jinja.pocoo.org/docs/dev/templates/#template-inheritance

Psycojoker commented 8 years ago

I think that we should also have a decorolation between menu displayed text and file name, something like:

- about: "Qui sommes nous ?"

instead of:

- "Qui sommes nous ?"

This will reduce the chance of breaking link because someone decided to change a menu title and the chance of generating bad file names (to be sure to avoid this problem we should slugify the text).

Psycojoker commented 8 years ago

9426503

(for reference)

Psycojoker commented 8 years ago

Also, I think that:

Oh, and one last thing, would you have the courage to ... update the README.md /o\?

I hope all those comments aren't too much :/

Oh and do try to merge with my master branch, I've made some heavy code modifications, I'll handle the merge myself ;)

And thanks a lot for this PR, it's a really cool feature :heart: