search

Psyop / Cryptomatte

Cryptomatte Nuke plugin, Fusion plugin, sample images, and specification
BSD 3-Clause "New" or "Revised" License
632 stars 151 forks source link

Updates the Fusion implementation to deal with the exponent properly when converting the hash to float #120

Closed lightwolf closed 3 years ago

lightwolf commented 4 years ago

I had to add the bit operators inline.

This fixes the issue where the fuse can't load the manifest because the hash to float conversion may create NaNs in some cases.

cedricduriau commented 3 years ago

Hi @lightwolf

Thanks a lot for taking the time to actually look into this and create the PR.

I realized that the Lua 5.2 bit module was backported to Lua 5.1 and is available builtin. I was able to cover your implementation with that builtin module just fine.

Issue: https://github.com/cedricduriau/Cryptomatte/issues/14 PR: https://github.com/cedricduriau/Cryptomatte/pull/15

Cheers Cedric

lightwolf commented 3 years ago

You're welcome. Sorry for the messy chode.

cedricduriau commented 3 years ago

You're welcome. Sorry for the messy chode.

No need to apologize, I can only appreciate the time and effort you took to do this.

jonahfriedman commented 3 years ago

Thanks everyone!