search

Psyop / CryptomatteArnold

Cryptomatte for Arnold
BSD 3-Clause "New" or "Revised" License
54 stars 19 forks source link

sidecar manifests are created even if there are no new outputs #11

Closed cpichard closed 1 year ago

cpichard commented 1 year ago

We found an issue where the sidecar manifests are not created when the cryptomatte aovs are defined in the scene. I believe the cryptomatte shader use to create cryptomatte aovs dynamically at render time, but now they might have been created by the user, this is how it works in solaris/htoa. However the code doesn't run the sidecar manifest creation if the cryptomatte aovs were not created by the shaders. This PR fixes this issue and allows the creation of sidecar manifests regardless of how the outputs aovs were created.

jonahfriedman commented 1 year ago

Hi @cpichard, I have made a new PR with one commit on top of yours. Can you review it please? It's #12.